Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support error handling in RebalanceCallback #128

Open
nikitapecasa opened this issue Apr 12, 2021 · 0 comments
Open

Support error handling in RebalanceCallback #128

nikitapecasa opened this issue Apr 12, 2021 · 0 comments

Comments

@nikitapecasa
Copy link
Contributor

This is a follow-up task to #122.

Currently errors from consumer related methods are thrown in a poll thread,
and there's no way to provide recovering code inside [[RebalanceCallback]].

For example:

def onPartitionsAssigned(partitions: Nes[TopicPartition]) = {
  for {
    state <- lift(restoreStateFor(partitions))
    _       <- state.offsets.traverse_(o => seek(o.partition, o.offset))
  } yield ()
}

if seek operation fails, exception is thrown in a poll thread, and user cannot provide recovering code while building a RebalanceCallback.

To fix it we need to implement MonadThrowable instance for RebalanceCallback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant