Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden ENV variable FS_API_PORT needs to be documented … #36

Closed
duncdrum opened this issue Apr 6, 2021 · 4 comments · Fixed by #39
Closed

Hidden ENV variable FS_API_PORT needs to be documented … #36

duncdrum opened this issue Apr 6, 2021 · 4 comments · Fixed by #39

Comments

@duncdrum
Copy link
Contributor

duncdrum commented Apr 6, 2021

Or even better drop Env variables all together, there is no reason to require the same info once as ENV variable and then again as system variable.

the source of much troubble

@duncdrum duncdrum changed the title Hidden ENV variable S_API_PORT needs to be documented … Hidden ENV variable FS_API_PORT needs to be documented … Apr 6, 2021
@adamretter
Copy link
Member

  1. I agree there should be only one setting
  2. It should work out-of-the-box with FusionDB nightly

@adamretter
Copy link
Member

At the moment, I can confirm that mvn verify works out of the box on a clean machine.
The only prerequisite is to add the auth for the Docker repo details to your ~/.m2/settings.xml, i.e.:

<server>
      <id>repo.evolvedbinary.com:9543</id>
      <username>your-username</username>
      <password>your-password</password>
</server>

Another option instead of editing ~/.m2/settings.xml is to pass them at runtime, e.g. mvn verify -Ddocker.username=your-username -Ddocker.password=your-password

@duncdrum
Copy link
Contributor Author

duncdrum commented Apr 6, 2021

@adamretter this info is part of #35, on clean system the command will work for either alpha or nightly not both, as the system needs to know the repo first.

where does fusions code come from on the clean system, if you follow the readme nothing has been cloned except the api code itself.

@adamretter
Copy link
Member

You can test against any image (both nightly and alpha), you just have to set the appropriate system properties. I am updating the README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants