Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand a collapsed collection when creating items #432

Merged
merged 2 commits into from
Aug 24, 2021
Merged

expand a collapsed collection when creating items #432

merged 2 commits into from
Aug 24, 2021

Conversation

ccheraa
Copy link
Member

@ccheraa ccheraa commented Jun 14, 2021 •
edited
Loading

fixes #413

@cla-bot cla-bot bot added the cla-signed label Jun 14, 2021
@duncdrum duncdrum self-requested a review July 1, 2021 10:52
duncdrum
duncdrum suggested changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thank you @ccheraa can you please adjust the new document test case to that the now correct behaviour is tested, so we avoid regressions.

@ccheraa ccheraa changed the title expand a collapsed collection when creating items [WIP] expand a collapsed collection when creating items Jul 23, 2021
@ccheraa
Copy link
Member Author

ccheraa commented Aug 17, 2021

@duncdrum we should merge this one without updating the tests, these tests are old anyway, and after #459, which contains new tests, is merged, we will add specific tests for this fix.

@duncdrum
Copy link
Contributor

@ccheraa sounds like it would make more sense to merge these two commits into the #459 and adjust the tests there then.

@adamretter adamretter merged commit 7d0d795 into evolvedbinary:master Aug 24, 2021
@ccheraa ccheraa changed the title [WIP] expand a collapsed collection when creating items expand a collapsed collection when creating items Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncdrum duncdrum duncdrum requested changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clicking on any of the "new document" templates should expand the treeview
3 participants
@ccheraa @duncdrum @adamretter