Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll back webpack workaround #511

Open
ccheraa opened this issue Sep 13, 2021 · 0 comments
Open

Roll back webpack workaround #511

ccheraa opened this issue Sep 13, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@ccheraa
Copy link
Member

ccheraa commented Sep 13, 2021

The workaround in PR #472 was meant to fix a problem where Theia tries to access the process variable on the web (process is available only in Electron context) resulting in an exception that prevents the app from starting.
That problem is fixed in Theia 1.17.0, so once we upgrade Theia, we should roll back the changes made in PR #472 .
duncdrum added a commit that referenced this issue Sep 14, 2021
@duncdrum
ci(e2e): switch ci to electron
6bea922 
see #452 #511
#id 158
duncdrum added a commit that referenced this issue Sep 14, 2021
@duncdrum
ci(e2e): switch ci to electron
7263fed 
see #452 #511
#id 158
@duncdrum duncdrum added the enhancement New feature or request label Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duncdrum @ccheraa