Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detached DOM elements .p-TabBar-tabCloseIcon #525

Open
duncdrum opened this issue Sep 23, 2021 · 0 comments
Open

detached DOM elements .p-TabBar-tabCloseIcon #525

duncdrum opened this issue Sep 23, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@duncdrum
Copy link
Contributor

while working on #518 I discovered a bunch of rogue dom elements.

As the screenshot shows, with only 1 visible closing tab icon (ignoring the non html5yness of <div class=…> instead of <button>) 10 additional elements are loaded into the browser and are hidden behind both the explorer and fusion tabs in the sidebar.

This is fubar, tested with chrome and ff without the cypress overlay. There really is no need to pollute the DOM with this kind of cruft, we need to figure out where its coming from and get rid of it. That should also help with

#521
#523
#413
#412

Screenshot 2021-09-23 at 14 41 11

@duncdrum duncdrum added the bug Something isn't working label Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant