Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minifying all css/js views should be an option #4

Open
mrclay opened this issue Feb 1, 2012 · 3 comments
Open

Minifying all css/js views should be an option #4

mrclay opened this issue Feb 1, 2012 · 3 comments

Comments

@mrclay
Copy link

mrclay commented Feb 1, 2012

I think it's dangerous to assume that any view with name starting with "css/" or "js/" is static across users/time. Sticking to css/elgg and js/elgg and maybe a few others would be far less risky. Also you'd get a performance increase because you could register only for those views instead of forcing every elgg_view call to execute your handler.

@cash
Copy link
Contributor

cash commented Feb 2, 2012

How about only minifying those registered for simplecache?

@mrclay
Copy link
Author

mrclay commented Feb 2, 2012

@cash Well that makes it easy!

@ewinslow
Copy link
Owner

ewinslow commented Feb 3, 2012

@cash, I think that's a good compromise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants