Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[⚡tests]: test coverage goal v4.10.0 - 5.0.0 #1786

Closed
11 of 15 tasks
ala-n opened this issue Jul 10, 2023 · 0 comments · Fixed by #1818
Closed
11 of 15 tasks

[⚡tests]: test coverage goal v4.10.0 - 5.0.0 #1786

ala-n opened this issue Jul 10, 2023 · 0 comments · Fixed by #1818
Assignees
Labels
multiple assignee Issue can have multiple assignees

Comments

@ala-n
Copy link
Collaborator

ala-n commented Jul 10, 2023

As for v4.10.0 the goal is to increase overall test coverage by up to 50%

Potential scope (splittable, feel free to create separate issues or skip items):

⚠️ IMPORTANT: split scope by separate branches/PRs, if the target scope is different of the diff, is big enough
⭐ NOTE: split tests by files even if they are related to the same submodule if that is reasonable from support perspective

Major:

  • [⚡for esl-utils] fix esl-utils/async/test/promise.raf.ts test file name
  • [⚡for esl-mixin-element] cover $$cls, $$attr, $$fire methods with unit tests
  • [⚡for esl-trigger] cover esl-trigger target to toggleable request delegation with unit tests
    Note: please make sure you create unit tests encapsulated enough - use fake ESLToggleable implementation, use fake events, and make cases clean, simple, and separated
  • [⚡for esl-trigger] cover esl-trigger toggleable tracking functionality with unit tests
    Note: please make sure you create unit tests encapsulated enough - use fake ESLToggleable implementation, use fake events, and make cases clean, simple, and separated
  • [⚡for esl-toggleable] cover esl-toggleable basic cases with unit tests
  • [⚡for esl-toggleable] cover esl-toggleable-dispatcher with unit tests

Normal:

  • [⚡for esl-toggleable] unit tests for body-class | container-class functionality of esl-toggleable
  • [⚡for esl-toggleable] unit tests for request:show|hide events of esl-toggleable
  • [⚡for esl-trigger] cover esl-trigger hover behavior with unit tests
    Note: please make sure you create unit tests encapsulated enough - use fake ESLToggleable implementation, use fake events, and make cases clean, simple, and separated
  • [⚡for esl-toggleable] unit tests for touch hover behavior of esl-toggleable
  • [⚡for esl-utils] improve poor esl-utils/dom/attr tests coverage
  • [⚡for esl-toggleable] basic integration tests for esl-trigger + esl-toggleable

Minor:

  • [⚡for esl-toggleable] unit tests for default a11ty of esl-toggleable
  • [⚡for esl-trigger] cover esl-trigger default a11ty with unit tests
    Note: please make sure you create unit tests encapsulated enough - use fake ESLToggleable implementation, use fake events, and make cases clean, simple, and separated
  • [⚡for esl-toggleable] unit tests for outside-action functionality of esl-toggleable
@ala-n ala-n added this to the ⚡ESL: 4.10.0 Minor release milestone Jul 10, 2023
@ala-n ala-n added the multiple assignee Issue can have multiple assignees label Jul 10, 2023
@fshovchko fshovchko linked a pull request Jul 18, 2023 that will close this issue
@ala-n ala-n linked a pull request Jul 28, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multiple assignee Issue can have multiple assignees
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants