epic(esl-media): rework commands API, add possibility to restrict play, handle containers #2942
+529
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toggleable # Conflicts: # src/modules/esl-media/core/esl-media.ts
feat(esl-media): observation for togglebale container state
… control low-level play call, prevent unnecessary player command execution (#2939) Useing ESLMediaManager to listen `esl-show` and `esl-hide` events of containers. TECH: add test page --------- Co-authored-by: ala'n (Alexey Stsefanovich) <astsefanovich@exadel.com>
ala-n
requested review from
abarmina and
NastaLeo
and removed request for
a team
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
dshovchko
approved these changes
Feb 18, 2025
Co-authored-by: Dmitry Shovchko <dshovchko@exadel.com>
abarmina
approved these changes
Feb 18, 2025
ala-n
commented
Feb 18, 2025
Co-authored-by: Anastasiya Lesun <72765981+NastaLeo@users.noreply.github.com>
test(esl-media): update tests, add BaseProvider & MediaManager livecycle tests
…eleaseAll` and `suspendAll` methods
…c/esl into epic/esl-media-manager # Conflicts: # src/modules/esl-media/test/media-manager.test.ts
dshovchko
approved these changes
Feb 20, 2025
ala-n
commented
Feb 20, 2025
src/modules/esl-media/core.ts
Outdated
| @@ -4,3 +4,4 @@ export * from './core/esl-media'; | |||
| export * from './core/esl-media-provider'; | |||
| export * from './core/esl-media-registry'; | |||
| export * from './control/esl-media-control-mixin'; | |||
| // export * from './core/esl-media-manager'; | |||
There was a problem hiding this comment.
Suggested change
| // export * from './core/esl-media-manager'; |
|
Code Climate has analyzed commit 71c4085 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 78.8% (50% is the threshold). This pull request will bring the total coverage in the repository to 63.5% (0.5% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2897
Closes: #2712