-
Notifications
You must be signed in to change notification settings - Fork 4
Closed
Description
Summary
Current sample flow validates merged spec and proceeds when there are warnings. For high-stakes runs, several warning classes are effectively correctness blockers and should fail early.
Why This Matters
Teams are repeatedly discovering issues downstream (DB contradictions, flat dynamics, no-op modifiers) that could have been blocked before sampling.
A strict gate profile would prevent recursive fix-run cycles.
Current Behavior (Code)
In /Users/adithyasrinivasan/Projects/extropy/extropy/cli/commands/sample.py:
- merged spec validation runs (
line ~165-172) - only errors block sampling (
line ~175) - warnings always pass (
line ~196-201)
Proposed Fix
Add a strict gate mode for sample (CLI flag and/or config), e.g. --strict-gates.
In strict mode, promote selected warning categories to errors, including at least:
- condition value mismatches
- modifier overlap ambiguity for categorical/boolean outcomes
- critical scenario validation warnings that imply no-op behavior
Design principles:
- deterministic and documented category list
- opt-in initially (to avoid breaking current users)
- printed summary of promoted warnings
Acceptance Criteria
extropy sample ... --strict-gatesfails when promoted warning categories are present.- Default mode behavior remains backward compatible.
- JSON output reports promoted categories and counts.
Pipeline Impact
Provides a reliable preflight quality gate for steps 1-3 before expensive downstream runs.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels