Skip to content

Commit 9d25437

Browse files
authored
#68: Add tests with Exasol v8 (#69)
1 parent 80423e8 commit 9d25437

File tree

11 files changed

+30
-11
lines changed

11 files changed

+30
-11
lines changed

.github/workflows/ci-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
cancel-in-progress: true
1616
runs-on: ubuntu-latest
1717
env:
18-
METABASE_TAG: v0.46.0
18+
METABASE_TAG: v0.46.5
1919
steps:
2020
- name: Checkout the repository
2121
uses: actions/checkout@v3

.github/workflows/integration-tests.yml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,15 @@ jobs:
1010
integration-test:
1111
strategy:
1212
fail-fast: true
13+
matrix:
14+
exasol_version: ["7.1.17", "8.18.1"]
1315
concurrency:
14-
group: ${{ github.workflow }}-${{ github.ref }}
16+
group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.exasol_version }}
1517
cancel-in-progress: true
18+
name: "Build with Exasol ${{ matrix.exasol_version }}"
1619
runs-on: ubuntu-latest
1720
env:
18-
METABASE_TAG: v0.46.0
21+
METABASE_TAG: v0.46.5
1922
steps:
2023
- name: Checkout the repository
2124
uses: actions/checkout@v3
@@ -36,6 +39,7 @@ jobs:
3639
with:
3740
fetch-depth: 1
3841
repository: 'exasol/integration-test-docker-environment'
42+
ref: "1.7.1"
3943
path: 'integration-test-docker-environment'
4044

4145
- name: Set up JDK 11
@@ -78,7 +82,10 @@ jobs:
7882
7983
- name: Spawn Exasol environment
8084
run: |
81-
./start-test-env spawn-test-environment --environment-name test --database-port-forward 8563
85+
./start-test-env spawn-test-environment \
86+
--environment-name test \
87+
--database-port-forward 8563 \
88+
--docker-db-image-version ${{ matrix.exasol_version }}
8289
working-directory: integration-test-docker-environment
8390

8491
- name: Run integration tests

.github/workflows/release_droid_upload_github_release_assets.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
build:
1212
runs-on: ubuntu-latest
1313
env:
14-
METABASE_TAG: v0.46.0
14+
METABASE_TAG: v0.46.5
1515
steps:
1616
- name: Checkout the repository
1717
uses: actions/checkout@v3

deps.edn

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
:aliases
1212
{:dev
1313
{:extra-deps
14-
{io.github.metabase/metabase {:git/tag "v0.46.0" :git/sha "0ca7df3"}}}
14+
{io.github.metabase/metabase {:git/tag "v0.46.5" :git/sha "0ca7df3"}}}
1515

1616
; clojure -M:clj-kondo --lint src test --debug
1717
:clj-kondo

doc/changes/changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# Changes
22

3+
* [1.0.6](changes_1.0.6.md)
34
* [1.0.5](changes_1.0.5.md)
45
* [1.0.4](changes_1.0.4.md)
56
* [1.0.3](changes_1.0.3.md)

doc/changes/changes_1.0.6.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# metabase-driver 1.0.6, released 2023-06-??
2+
3+
Code name: Test with Exasol 8
4+
5+
## Summary
6+
7+
This release adds tests for Exasol version 8 and adapts the driver to Metabase v0.46.5.
8+
9+
## Tests
10+
11+
* #68: Added tests with Exasol version 8

doc/developer_guide/developer_guide.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ clojure --version
4545
git clone https://github.com/metabase/metabase.git
4646
cd metabase
4747
git fetch --all --tags
48-
export METABASE_VERSION=v0.46.0
48+
export METABASE_VERSION=v0.46.5
4949
git reset --hard
5050
rm -vf target/patch_excluded_test_applied target/patch_fix_metabase_build_applied
5151
git checkout "tags/${METABASE_VERSION}" -b "${METABASE_VERSION}-branch"

resources/metabase-plugin.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Complete list of options here: https://github.com/metabase/metabase/wiki/Metabase-Plugin-Manifest-Reference
22
info:
33
name: Metabase Exasol Driver
4-
version: 1.0.5
4+
version: 1.0.6
55
description: Allows Metabase to connect to Exasol databases.
66
contact-info:
77
name: Exasol AG

scripts/run-integration-tests.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ set -o errexit
44
set -o nounset
55
set -o pipefail
66

7-
readonly jdbc_driver_version=7.1.19
7+
readonly jdbc_driver_version=7.1.20
88

99
exasol_driver_dir="$( cd "$(dirname "$0")/.." >/dev/null 2>&1 ; pwd -P )"
1010
metabase_dir=$(cd "$exasol_driver_dir/../metabase"; pwd)

test/metabase/driver/exasol_test.clj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
(testing "Getting JDBC driver version succeeds"
1616
(is (not (str/blank? (exasol/get-jdbc-driver-version)))))
1717
(testing "Getting JDBC driver version returns expected value"
18-
(is (= "7.1.19" (exasol/get-jdbc-driver-version)))))
18+
(is (= "7.1.20" (exasol/get-jdbc-driver-version)))))
1919

2020
(deftest text-equals-empty-string-test
2121
(mt/test-driver :exasol

test/metabase/driver/exasol_unit_test.clj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@
179179
(testing "Driver version read from existing resource"
180180
(is (not (str/blank? (exasol/get-driver-version)))))
181181
(testing "Driver version read from existing resource equal to expected version"
182-
(is (= "1.0.5" (exasol/get-driver-version)))))
182+
(is (= "1.0.6" (exasol/get-driver-version)))))
183183

184184
(deftest humanize-connection-error-message-test
185185
(testing "Driver translates connection error message"

0 commit comments

Comments
 (0)