Skip to content

Commit 4b35f94

Browse files
authored
Refactorings Script Options Parser
closes #990: Forward JAR options without changing order to classpath closes #989: Trim script class and import script options closes #993: Added escape sequence for backslash in new Script Options parser closes #986: Added environment variable for new ScriptOptionsLine parser in UDF client
1 parent 430eb35 commit 4b35f94

File tree

4 files changed

+16
-3
lines changed

4 files changed

+16
-3
lines changed

.current_gitmodules

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

doc/changes/changes_8.4.0.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,13 @@ This release uses version 1.0.0 of the container tool.
3131
- #971: Removed dead code in Java VM
3232
- #982: Added a performance test for ScriptOptions parser for a single line UDF
3333
- #983: Refactor CTPG script options Java parser code
34+
- #986: Added environment variable for new ScriptOptionsLine parser in UDF client
35+
- #990: Forward JAR options without changing order to classpath
36+
- #989: Trim script class and import script options
3437

3538
## Bugs
3639
- #977: Fixed Trivy update cache workflow
40+
- #993: Added escape sequence for backslash in new Script Options parser
3741

3842
## Doc
3943

exaudfclient/exaudfclient.cc

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,10 @@ int main(int argc, char **argv) {
129129
cerr << "Usage: " << argv[0] << " <socket> lang=python|lang=r|lang=java|lang=streaming|lang=benchmark" << endl;
130130
return 1;
131131
}
132+
const char* script_options_parser_env_val = ::getenv("SCRIPT_OPTIONS_PARSER_VERSION");
133+
const bool useCtpgScriptOptionsParser = script_options_parser_env_val != nullptr &&
134+
::strcmp(script_options_parser_env_val, "2") == 0;
135+
132136
#endif
133137

134138
if (::setenv("HOME", "/tmp", 1) == -1)
@@ -167,7 +171,12 @@ int main(int argc, char **argv) {
167171
} else if (strcmp(argv[2], "lang=java")==0)
168172
{
169173
#ifdef ENABLE_JAVA_VM
170-
vmMaker = [&](){return SWIGVMContainers::JavaContainerBuilder().build();};
174+
if (useCtpgScriptOptionsParser) {
175+
vmMaker = [&](){return SWIGVMContainers::JavaContainerBuilder().useCtpgParser().build();};
176+
} else {
177+
vmMaker = [&](){return SWIGVMContainers::JavaContainerBuilder().build();};
178+
}
179+
171180
#else
172181
throw SWIGVM::exception("this exaudfclient has been compilied without Java support");
173182
#endif

script-languages

Submodule script-languages updated 32 files

0 commit comments

Comments
 (0)