General cleanup from editorconfig warnings

Author: niemyjski

src/Exceptionless.Api/Controllers/AuthController.cs

@@ -154,7 +154,7 @@ public async Task<IHttpActionResult> LoginAsync(LoginModel model) {
         [Route("signup")]
         [ResponseType(typeof(TokenResult))]
         public async Task<IHttpActionResult> SignupAsync(SignupModel model) {
-            var valid = await IsAccountCreationEnabledAsync(model?.InviteToken);
+            bool valid = await IsAccountCreationEnabledAsync(model?.InviteToken);
             if (!valid)
                 return BadRequest("Account Creation is currently disabled.");
 
@@ -220,7 +220,7 @@ public async Task<IHttpActionResult> SignupAsync(SignupModel model) {
             try {
                 user = await _userRepository.AddAsync(user, true);
             } catch (ValidationException ex) {
-                var errors = String.Join(", ", ex.Errors);
+                string errors = String.Join(", ", ex.Errors);
                 _logger.Error().Critical().Message("Signup failed for \"{0}\": {1}", email, errors).Tag("Signup").Identity(user.EmailAddress).Property("User", user).SetActionContext(ActionContext).Write();
                 return BadRequest(errors);
             } catch (Exception ex) {

src/Exceptionless.Core/Extensions/PersistentEventExtensions.cs

@@ -36,7 +36,7 @@ public static void CopyDataToIndex(this PersistentEvent ev, params string[] keys
                 } else if (dataType == typeof(DateTime) || dataType == typeof(DateTimeOffset)) {
                     ev.Idx[field + "-d"] = ev.Data[key];
                 } else if (dataType == typeof(string)) {
-                    var input = (string)ev.Data[key];
+                    string input = (string)ev.Data[key];
                     if (String.IsNullOrEmpty(input) || input.Length >= 1000)
                         continue;
 
@@ -48,8 +48,8 @@ public static void CopyDataToIndex(this PersistentEvent ev, params string[] keys
 
                     bool value;
                     DateTimeOffset dtoValue;
-                    Decimal decValue;
-                    Double dblValue;
+                    decimal decValue;
+                    double dblValue;
                     if (Boolean.TryParse(input, out value))
                         ev.Idx[field + "-b"] = value;
                     else if (DateTimeOffset.TryParse(input, out dtoValue))
@@ -217,13 +217,13 @@ public static IEnumerable<string> GetIpAddresses(this PersistentEvent ev) {
 
             var ri = ev.GetRequestInfo();
             if (!String.IsNullOrEmpty(ri?.ClientIpAddress)) {
-                foreach (var ip in ri.ClientIpAddress.Split(new[] { ',' }, StringSplitOptions.RemoveEmptyEntries))
+                foreach (string ip in ri.ClientIpAddress.Split(new[] { ',' }, StringSplitOptions.RemoveEmptyEntries))
                     yield return ip.Trim();
             }
 
             var ei = ev.GetEnvironmentInfo();
             if (!String.IsNullOrEmpty(ei?.IpAddress)) {
-                foreach (var ip in ei.IpAddress.Split(new[] { ',' }, StringSplitOptions.RemoveEmptyEntries))
+                foreach (string ip in ei.IpAddress.Split(new[] { ',' }, StringSplitOptions.RemoveEmptyEntries))
                     yield return ip.Trim();
             }
         }

src/Exceptionless.Core/Repositories/EventRepository.cs

@@ -136,8 +136,8 @@ public Task<FindResults<PersistentEvent>> GetByReferenceIdAsync(string projectId
         }
 
         public async Task<PreviousAndNextEventIdResult> GetPreviousAndNextEventIdsAsync(PersistentEvent ev, IExceptionlessSystemFilterQuery systemFilter, string userFilter, DateTime? utcStart, DateTime? utcEnd) {
-            var previous = await GetPreviousEventIdAsync(ev, systemFilter, userFilter, utcStart, utcEnd).AnyContext();
-            var next = await GetNextEventIdAsync(ev, systemFilter, userFilter, utcStart, utcEnd).AnyContext();
+            string previous = await GetPreviousEventIdAsync(ev, systemFilter, userFilter, utcStart, utcEnd).AnyContext();
+            string next = await GetNextEventIdAsync(ev, systemFilter, userFilter, utcStart, utcEnd).AnyContext();
 
             return new PreviousAndNextEventIdResult {
                 Previous = previous,
@@ -187,7 +187,7 @@ private async Task<string> GetPreviousEventIdAsync(PersistentEvent ev, IExceptio
                 .OrderBy(t => t.Date.UtcTicks).ThenBy(t => t.Id)
                 .ToList();
 
-            var index = unionResults.FindIndex(t => t.Id == ev.Id);
+            int index = unionResults.FindIndex(t => t.Id == ev.Id);
             return index == 0 ? null : unionResults[index - 1].Id;
         }
 
@@ -232,7 +232,7 @@ private async Task<string> GetNextEventIdAsync(PersistentEvent ev, IExceptionles
                 .OrderBy(t => t.Date.Ticks).ThenBy(t => t.Id)
                 .ToList();
 
-            var index = unionResults.FindIndex(t => t.Id == ev.Id);
+            int index = unionResults.FindIndex(t => t.Id == ev.Id);
             return index == unionResults.Count - 1 ? null : unionResults[index + 1].Id;
         }
 

tests/Exceptionless.Api.Tests/Search/EventIndexTests.cs

@@ -447,7 +447,7 @@ public async Task GetByCustomDataAsync(string filter, int count) {
 
         private async Task CreateEventsAsync() {
             var parserPluginManager = GetService<EventParserPluginManager>();
-            foreach (var file in Directory.GetFiles(@"..\..\Search\Data\", "event*.json", SearchOption.AllDirectories)) {
+            foreach (string file in Directory.GetFiles(@"..\..\Search\Data\", "event*.json", SearchOption.AllDirectories)) {
                 if (file.EndsWith("summary.json"))
                     continue;
 

tests/Exceptionless.Api.Tests/Search/StackIndexTests.cs

@@ -174,7 +174,7 @@ public async Task GetByDescriptionAsync(string filter, int count) {
 
         private async Task CreateDataAsync() {
             var serializer = GetService<JsonSerializer>();
-            foreach (var file in Directory.GetFiles(@"..\..\Search\Data\", "stack*.json", SearchOption.AllDirectories)) {
+            foreach (string file in Directory.GetFiles(@"..\..\Search\Data\", "stack*.json", SearchOption.AllDirectories)) {
                 if (file.EndsWith("summary.json"))
                     continue;