Shorten up metric names so they meet otel standards

ejsmith · ejsmith · commit 30c1fe0b3be7 · 2023-07-26T23:38:39.000-05:00
diff --git a/k8s/ex-prod-elasticsearch.yaml b/k8s/ex-prod-elasticsearch.yaml
@@ -16,9 +16,7 @@ spec:
     - name: main-v2
       count: 4
       config:
-        node.master: true
-        node.data: true
-        node.ingest: true
+        node.roles: [data, ingest, master]
         action.destructive_requires_name: true
         # if not setting max_map_count in an init container, then use this setting
         #node.store.allow_mmap: false
diff --git a/k8s/ex-prod-values.yaml b/k8s/ex-prod-values.yaml
@@ -36,7 +36,7 @@ config:
   EX_SmtpFrom: "Exceptionless <noreply@exceptionless.io>"
   EX_TestEmailAddress: "test@exceptionless.io"
   EX_EnableArchive: "false"
-  EX_Apm__Endpoint: http://ex-prod-monitor-apm-http:8200
+  EX_Apm__Endpoint: http://apm.elastic-system.svc:8200
   EX_Apm__EnableLogs: "true"
   EX_Apm__EnableMetrics: "true"
   EX_Apm__EnableTracing: "true"
diff --git a/k8s/ex-setup.ps1 b/k8s/ex-setup.ps1
@@ -12,6 +12,7 @@ choco install azure-cli
 choco install kubernetes-helm
 helm repo add "stable" "https://charts.helm.sh/stable" --force-update
 helm repo add jetstack https://charts.jetstack.io
+helm repo add prometheus-community https://prometheus-community.github.io/helm-charts                                                                                                                     ❮  3s 868ms   
 helm repo update
 
 ### setup
@@ -98,6 +99,9 @@ curl -X PUT -H "Content-Type: application/json" -k `
 
 Remove-Job $ELASTIC_JOB
 
+# install kube-state-metrics
+helm install --namespace elastic-system kube-state-metrics prometheus-community/kube-state-metrics
+
 # install nginx ingress
 helm install --namespace ingress-nginx -f nginx-values.yaml ingress-nginx ingress-nginx/ingress-nginx
 
diff --git a/src/Exceptionless.Core/Pipeline/Base/PipelineBase.cs b/src/Exceptionless.Core/Pipeline/Base/PipelineBase.cs
@@ -18,7 +18,7 @@ namespace Exceptionless.Core.Pipeline;
 /// </remarks>
 public abstract class PipelineBase<TContext, TAction> where TAction : class, IPipelineAction<TContext> where TContext : IPipelineContext
 {
-    protected static readonly ConcurrentDictionary<Type, IList<Type>> _actionTypeCache = new ConcurrentDictionary<Type, IList<Type>>();
+    protected static readonly ConcurrentDictionary<Type, IList<Type>> _actionTypeCache = new();
     private readonly IServiceProvider _serviceProvider;
     private readonly AppOptions _options;
     private readonly IList<IPipelineAction<TContext>> _actions;
@@ -31,7 +31,7 @@ public PipelineBase(IServiceProvider serviceProvider, AppOptions options, ILogge
         _options = options;
 
         var type = GetType();
-        _metricPrefix = String.Concat("pipeline.", type.Name.ToLower(), ".");
+        _metricPrefix = String.Concat(type.Name.ToLower(), ".");
         _logger = loggerFactory?.CreateLogger(type);
 
         _actions = LoadDefaultActions();
@@ -55,10 +55,9 @@ public virtual async Task<ICollection<TContext>> RunAsync(ICollection<TContext>
     {
         PipelineRunning(contexts);
 
-        string metricPrefix = String.Concat(_metricPrefix, nameof(RunAsync).ToLower(), ".");
         foreach (var action in _actions)
         {
-            string metricName = String.Concat(metricPrefix, action.Name.ToLower());
+            string metricName = String.Concat(_metricPrefix, action.Name.ToLower());
             var contextsToProcess = contexts.Where(c => c.IsCancelled == false && !c.HasError).ToList();
             await AppDiagnostics.TimeAsync(() => action.ProcessBatchAsync(contextsToProcess), metricName).AnyContext();
             if (contextsToProcess.All(c => c.IsCancelled || c.HasError))
diff --git a/src/Exceptionless.Core/Plugins/EventProcessor/EventPluginManager.cs b/src/Exceptionless.Core/Plugins/EventProcessor/EventPluginManager.cs
@@ -12,12 +12,11 @@ public EventPluginManager(IServiceProvider serviceProvider, AppOptions options,
     /// </summary>
     public async Task StartupAsync()
     {
-        string metricPrefix = String.Concat("events.startup.");
         foreach (var plugin in Plugins.Values.ToList())
         {
             try
             {
-                string metricName = String.Concat(metricPrefix, plugin.Name.ToLower());
+                string metricName = String.Concat(_metricPrefix, plugin.Name.ToLower());
                 await AppDiagnostics.TimeAsync(() => plugin.StartupAsync(), metricName).AnyContext();
             }
             catch (Exception ex)
@@ -32,14 +31,13 @@ public async Task StartupAsync()
     /// </summary>
     public async Task EventBatchProcessingAsync(ICollection<EventContext> contexts)
     {
-        string metricPrefix = String.Concat(_metricPrefix, "events.processing.");
         foreach (var plugin in Plugins.Values)
         {
             var contextsToProcess = contexts.Where(c => c.IsCancelled == false && !c.HasError).ToList();
             if (contextsToProcess.Count == 0)
                 break;
 
-            string metricName = String.Concat(metricPrefix, plugin.Name.ToLower());
+            string metricName = String.Concat(_metricPrefix, plugin.Name.ToLower());
             try
             {
                 await AppDiagnostics.TimeAsync(() => plugin.EventBatchProcessingAsync(contextsToProcess), metricName).AnyContext();
@@ -58,14 +56,13 @@ public async Task EventBatchProcessingAsync(ICollection<EventContext> contexts)
     /// </summary>
     public async Task EventBatchProcessedAsync(ICollection<EventContext> contexts)
     {
-        string metricPrefix = String.Concat("events.processed.");
         foreach (var plugin in Plugins.Values)
         {
             var contextsToProcess = contexts.Where(c => c.IsCancelled == false && !c.HasError).ToList();
             if (contextsToProcess.Count == 0)
                 break;
 
-            string metricName = String.Concat(metricPrefix, plugin.Name.ToLower());
+            string metricName = String.Concat(_metricPrefix, plugin.Name.ToLower());
             try
             {
                 await AppDiagnostics.TimeAsync(() => plugin.EventBatchProcessedAsync(contextsToProcess), metricName).AnyContext();
diff --git a/src/Exceptionless.Core/Plugins/PluginManagerBase.cs b/src/Exceptionless.Core/Plugins/PluginManagerBase.cs
@@ -14,7 +14,7 @@ public abstract class PluginManagerBase<TPlugin> where TPlugin : class, IPlugin
     public PluginManagerBase(IServiceProvider serviceProvider, AppOptions options, ILoggerFactory loggerFactory = null)
     {
         var type = GetType();
-        _metricPrefix = String.Concat("plugin.");
+        _metricPrefix = "";
         _logger = loggerFactory?.CreateLogger(type);
         _serviceProvider = serviceProvider;
         _options = options;
@@ -42,7 +42,7 @@ private void LoadDefaultPlugins()
         {
             if (_options.DisabledPlugins.Contains(type.Name, StringComparer.InvariantCultureIgnoreCase))
             {
-                _logger.LogWarning("Plugin {TypeName} is currently disabled and won't be executed.", type.Name);
+                _logger.LogWarning("Plugin {TypeName} is currently disabled and won't be executed", type.Name);
                 continue;
             }
 
diff --git a/src/Exceptionless.Core/Plugins/WebHook/WebHookDataPluginManager.cs b/src/Exceptionless.Core/Plugins/WebHook/WebHookDataPluginManager.cs
@@ -12,7 +12,7 @@ public WebHookDataPluginManager(IServiceProvider serviceProvider, AppOptions opt
     /// </summary>
     public async Task<object> CreateFromEventAsync(WebHookDataContext context)
     {
-        string metricPrefix = String.Concat(_metricPrefix, nameof(CreateFromEventAsync).ToLower(), ".");
+        string metricPrefix = String.Concat(_metricPrefix, "ev-create", ".");
         foreach (var plugin in Plugins.Values)
         {
             string metricName = String.Concat(metricPrefix, plugin.Name.ToLower());
@@ -42,7 +42,7 @@ public async Task<object> CreateFromEventAsync(WebHookDataContext context)
     /// </summary>
     public async Task<object> CreateFromStackAsync(WebHookDataContext context)
     {
-        string metricPrefix = String.Concat(_metricPrefix, nameof(CreateFromStackAsync).ToLower(), ".");
+        string metricPrefix = String.Concat(_metricPrefix, "st-create", ".");
         foreach (var plugin in Plugins.Values)
         {
             string metricName = String.Concat(metricPrefix, plugin.Name.ToLower());
diff --git a/src/Exceptionless.Core/Utility/AppDiagnostics.cs b/src/Exceptionless.Core/Utility/AppDiagnostics.cs
@@ -12,7 +12,7 @@ public static class AppDiagnostics
     internal static readonly string AssemblyVersion = typeof(AppDiagnostics).Assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>()?.InformationalVersion ?? AssemblyName.Version.ToString();
     internal static readonly ActivitySource ActivitySource = new(AssemblyName.Name, AssemblyVersion);
     internal static readonly Meter Meter = new("Exceptionless", AssemblyVersion);
-    private static readonly string _metricsPrefix = "exceptionless.";
+    private static readonly string _metricsPrefix = "ex.";
 
     private static readonly ConcurrentDictionary<string, Counter<int>> _counters = new();
     private static readonly ConcurrentDictionary<string, GaugeInfo> _gauges = new();
@@ -79,38 +79,38 @@ public GaugeInfo(Meter meter, string name)
         public double Value { get; set; }
     }
 
-    internal static readonly Counter<int> EventsSubmitted = Meter.CreateCounter<int>("exceptionless.events.submitted", description: "Events submitted to the pipeline to be processed");
-    internal static readonly Counter<int> EventsProcessed = Meter.CreateCounter<int>("exceptionless.events.all.processed", description: "Events successfully processed by the pipeline");
-    internal static readonly Histogram<double> EventsProcessingTime = Meter.CreateHistogram<double>("exceptionless.events.processingtime", description: "Time to process an event", unit: "ms");
-    internal static readonly Counter<int> EventsPaidProcessed = Meter.CreateCounter<int>("exceptionless.events.paid.processed", description: "Paid events processed");
-    internal static readonly Counter<int> EventsProcessErrors = Meter.CreateCounter<int>("exceptionless.events.processing.errors", description: "Errors processing events");
-    internal static readonly Counter<int> EventsDiscarded = Meter.CreateCounter<int>("exceptionless.events.discarded", description: "Events that were discarded");
-    internal static readonly Counter<int> EventsBlocked = Meter.CreateCounter<int>("exceptionless.events.blocked", description: "Events that were blocked");
-    internal static readonly Counter<int> EventsProcessCancelled = Meter.CreateCounter<int>("exceptionless.events.processing.cancelled", description: "Events that started processing and were cancelled");
-    internal static readonly Counter<int> EventsRetryCount = Meter.CreateCounter<int>("exceptionless.events.retry.count", description: "Events where processing was retried");
-    internal static readonly Counter<int> EventsRetryErrors = Meter.CreateCounter<int>("exceptionless.events.retry.errors", description: "Events where retry processing got an error");
-    internal static readonly Histogram<double> EventsFieldCount = Meter.CreateHistogram<double>("exceptionless.events.field.count", description: "Number of fields per event");
-
-    internal static readonly Counter<int> PostsParsed = Meter.CreateCounter<int>("exceptionless.posts.parsed", description: "Post batch submission parsed");
-    internal static readonly Histogram<double> PostsEventCount = Meter.CreateHistogram<double>("exceptionless.posts.eventcount", description: "Number of events in post batch submission");
-    internal static readonly Histogram<double> PostsSize = Meter.CreateHistogram<double>("exceptionless.posts.size", description: "Size of post batch submission", unit: "bytes");
-    internal static readonly Counter<int> PostsParseErrors = Meter.CreateCounter<int>("exceptionless.posts.parse.errors", description: "Error parsing post batch submission");
-    internal static readonly Histogram<double> PostsMarkFileActiveTime = Meter.CreateHistogram<double>("exceptionless.posts.markfileactivetime", description: "Time to mark a post submission file active", unit: "ms");
-    internal static readonly Histogram<double> PostsParsingTime = Meter.CreateHistogram<double>("exceptionless.posts.parsingtime", description: "Time to parse post batch submission", unit: "ms");
-    internal static readonly Histogram<double> PostsRetryTime = Meter.CreateHistogram<double>("exceptionless.posts.retrytime", description: "Time to retry post batch parsing", unit: "ms");
-    internal static readonly Histogram<double> PostsAbandonTime = Meter.CreateHistogram<double>("exceptionless.posts.abandontime", description: "Time to abandon post", unit: "ms");
-    internal static readonly Histogram<double> PostsCompleteTime = Meter.CreateHistogram<double>("exceptionless.posts.completetime", description: "Time to complete a post", unit: "ms");
-    internal static readonly Counter<int> PostsDiscarded = Meter.CreateCounter<int>("exceptionless.posts.discarded", description: "Post batch submissions discarded");
-    internal static readonly Counter<int> PostTooBig = Meter.CreateCounter<int>("exceptionless.posts.toobig", description: "Post batch submission too big");
-    internal static readonly Counter<int> PostsBlocked = Meter.CreateCounter<int>("exceptionless.posts.blocked", description: "Post batch submission blocked");
-
-    internal static readonly Histogram<long> PostsMessageSize = Meter.CreateHistogram<long>("exceptionless.posts.message.size", description: "Size of posts", unit: "bytes");
-    internal static readonly Histogram<double> PostsCompressedSize = Meter.CreateHistogram<double>("exceptionless.posts.compressed.size", description: "Size of compressed post", unit: "bytes");
-    internal static readonly Histogram<double> PostsUncompressedSize = Meter.CreateHistogram<double>("exceptionless.posts.uncompressed.size", description: "Size of uncompressed post", unit: "bytes");
-    internal static readonly Histogram<double> PostsDecompressionTime = Meter.CreateHistogram<double>("exceptionless.posts.decompression.time", description: "Time to get event post", unit: "ms");
-    internal static readonly Counter<int> PostsDecompressionErrors = Meter.CreateCounter<int>("exceptionless.posts.decompression.errors", description: "Time to get event post");
-
-    internal static readonly Counter<int> UsageGeocodingApi = Meter.CreateCounter<int>("exceptionless.usage.geocoding", description: "Geocode API calls");
+    internal static readonly Counter<int> EventsSubmitted = Meter.CreateCounter<int>("ex.events.submitted", description: "Events submitted to the pipeline to be processed");
+    internal static readonly Counter<int> EventsProcessed = Meter.CreateCounter<int>("ex.events.all.processed", description: "Events successfully processed by the pipeline");
+    internal static readonly Histogram<double> EventsProcessingTime = Meter.CreateHistogram<double>("ex.events.processingtime", description: "Time to process an event", unit: "ms");
+    internal static readonly Counter<int> EventsPaidProcessed = Meter.CreateCounter<int>("ex.events.paid.processed", description: "Paid events processed");
+    internal static readonly Counter<int> EventsProcessErrors = Meter.CreateCounter<int>("ex.events.processing.errors", description: "Errors processing events");
+    internal static readonly Counter<int> EventsDiscarded = Meter.CreateCounter<int>("ex.events.discarded", description: "Events that were discarded");
+    internal static readonly Counter<int> EventsBlocked = Meter.CreateCounter<int>("ex.events.blocked", description: "Events that were blocked");
+    internal static readonly Counter<int> EventsProcessCancelled = Meter.CreateCounter<int>("ex.events.processing.cancelled", description: "Events that started processing and were cancelled");
+    internal static readonly Counter<int> EventsRetryCount = Meter.CreateCounter<int>("ex.events.retry.count", description: "Events where processing was retried");
+    internal static readonly Counter<int> EventsRetryErrors = Meter.CreateCounter<int>("ex.events.retry.errors", description: "Events where retry processing got an error");
+    internal static readonly Histogram<double> EventsFieldCount = Meter.CreateHistogram<double>("ex.events.field.count", description: "Number of fields per event");
+
+    internal static readonly Counter<int> PostsParsed = Meter.CreateCounter<int>("ex.posts.parsed", description: "Post batch submission parsed");
+    internal static readonly Histogram<double> PostsEventCount = Meter.CreateHistogram<double>("ex.posts.eventcount", description: "Number of events in post batch submission");
+    internal static readonly Histogram<double> PostsSize = Meter.CreateHistogram<double>("ex.posts.size", description: "Size of post batch submission", unit: "bytes");
+    internal static readonly Counter<int> PostsParseErrors = Meter.CreateCounter<int>("ex.posts.parse.errors", description: "Error parsing post batch submission");
+    internal static readonly Histogram<double> PostsMarkFileActiveTime = Meter.CreateHistogram<double>("ex.posts.markfileactivetime", description: "Time to mark a post submission file active", unit: "ms");
+    internal static readonly Histogram<double> PostsParsingTime = Meter.CreateHistogram<double>("ex.posts.parsingtime", description: "Time to parse post batch submission", unit: "ms");
+    internal static readonly Histogram<double> PostsRetryTime = Meter.CreateHistogram<double>("ex.posts.retrytime", description: "Time to retry post batch parsing", unit: "ms");
+    internal static readonly Histogram<double> PostsAbandonTime = Meter.CreateHistogram<double>("ex.posts.abandontime", description: "Time to abandon post", unit: "ms");
+    internal static readonly Histogram<double> PostsCompleteTime = Meter.CreateHistogram<double>("ex.posts.completetime", description: "Time to complete a post", unit: "ms");
+    internal static readonly Counter<int> PostsDiscarded = Meter.CreateCounter<int>("ex.posts.discarded", description: "Post batch submissions discarded");
+    internal static readonly Counter<int> PostTooBig = Meter.CreateCounter<int>("ex.posts.toobig", description: "Post batch submission too big");
+    internal static readonly Counter<int> PostsBlocked = Meter.CreateCounter<int>("ex.posts.blocked", description: "Post batch submission blocked");
+
+    internal static readonly Histogram<long> PostsMessageSize = Meter.CreateHistogram<long>("ex.posts.message.size", description: "Size of posts", unit: "bytes");
+    internal static readonly Histogram<double> PostsCompressedSize = Meter.CreateHistogram<double>("ex.posts.compressed.size", description: "Size of compressed post", unit: "bytes");
+    internal static readonly Histogram<double> PostsUncompressedSize = Meter.CreateHistogram<double>("ex.posts.uncompressed.size", description: "Size of uncompressed post", unit: "bytes");
+    internal static readonly Histogram<double> PostsDecompressionTime = Meter.CreateHistogram<double>("ex.posts.decompression.time", description: "Time to get event post", unit: "ms");
+    internal static readonly Counter<int> PostsDecompressionErrors = Meter.CreateCounter<int>("ex.posts.decompression.errors", description: "Time to get event post");
+
+    internal static readonly Counter<int> UsageGeocodingApi = Meter.CreateCounter<int>("ex.usage.geocoding", description: "Geocode API calls");
 }
 
 public static class MetricsClientExtensions

Original file line number	Diff line number	Diff line change
`@@ -12,12 +12,11 @@ public EventPluginManager(IServiceProvider serviceProvider, AppOptions options,`
`12`	`12`	`/// </summary>`
`13`	`13`	`public async Task StartupAsync()`
`14`	`14`	`{`
`15`		`- string metricPrefix = String.Concat("events.startup.");`
`16`	`15`	`foreach (var plugin in Plugins.Values.ToList())`
`17`	`16`	`{`
`18`	`17`	`try`
`19`	`18`	`{`
`20`		`- string metricName = String.Concat(metricPrefix, plugin.Name.ToLower());`
	`19`	`+ string metricName = String.Concat(_metricPrefix, plugin.Name.ToLower());`
`21`	`20`	`await AppDiagnostics.TimeAsync(() => plugin.StartupAsync(), metricName).AnyContext();`
`22`	`21`	`}`
`23`	`22`	`catch (Exception ex)`
`@@ -32,14 +31,13 @@ public async Task StartupAsync()`
`32`	`31`	`/// </summary>`
`33`	`32`	`public async Task EventBatchProcessingAsync(ICollection<EventContext> contexts)`
`34`	`33`	`{`
`35`		`- string metricPrefix = String.Concat(_metricPrefix, "events.processing.");`
`36`	`34`	`foreach (var plugin in Plugins.Values)`
`37`	`35`	`{`
`38`	`36`	`var contextsToProcess = contexts.Where(c => c.IsCancelled == false && !c.HasError).ToList();`
`39`	`37`	`if (contextsToProcess.Count == 0)`
`40`	`38`	`break;`
`41`	`39`
`42`		`- string metricName = String.Concat(metricPrefix, plugin.Name.ToLower());`
	`40`	`+ string metricName = String.Concat(_metricPrefix, plugin.Name.ToLower());`
`43`	`41`	`try`
`44`	`42`	`{`
`45`	`43`	`await AppDiagnostics.TimeAsync(() => plugin.EventBatchProcessingAsync(contextsToProcess), metricName).AnyContext();`
`@@ -58,14 +56,13 @@ public async Task EventBatchProcessingAsync(ICollection<EventContext> contexts)`
`58`	`56`	`/// </summary>`
`59`	`57`	`public async Task EventBatchProcessedAsync(ICollection<EventContext> contexts)`
`60`	`58`	`{`
`61`		`- string metricPrefix = String.Concat("events.processed.");`
`62`	`59`	`foreach (var plugin in Plugins.Values)`
`63`	`60`	`{`
`64`	`61`	`var contextsToProcess = contexts.Where(c => c.IsCancelled == false && !c.HasError).ToList();`
`65`	`62`	`if (contextsToProcess.Count == 0)`
`66`	`63`	`break;`
`67`	`64`
`68`		`- string metricName = String.Concat(metricPrefix, plugin.Name.ToLower());`
	`65`	`+ string metricName = String.Concat(_metricPrefix, plugin.Name.ToLower());`
`69`	`66`	`try`
`70`	`67`	`{`
`71`	`68`	`await AppDiagnostics.TimeAsync(() => plugin.EventBatchProcessedAsync(contextsToProcess), metricName).AnyContext();`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ public abstract class PluginManagerBase<TPlugin> where TPlugin : class, IPlugin`
`14`	`14`	`public PluginManagerBase(IServiceProvider serviceProvider, AppOptions options, ILoggerFactory loggerFactory = null)`
`15`	`15`	`{`
`16`	`16`	`var type = GetType();`
`17`		`- _metricPrefix = String.Concat("plugin.");`
	`17`	`+ _metricPrefix = "";`
`18`	`18`	`_logger = loggerFactory?.CreateLogger(type);`
`19`	`19`	`_serviceProvider = serviceProvider;`
`20`	`20`	`_options = options;`
`@@ -42,7 +42,7 @@ private void LoadDefaultPlugins()`
`42`	`42`	`{`
`43`	`43`	`if (_options.DisabledPlugins.Contains(type.Name, StringComparer.InvariantCultureIgnoreCase))`
`44`	`44`	`{`
`45`		`- _logger.LogWarning("Plugin {TypeName} is currently disabled and won't be executed.", type.Name);`
	`45`	`+ _logger.LogWarning("Plugin {TypeName} is currently disabled and won't be executed", type.Name);`
`46`	`46`	`continue;`
`47`	`47`	`}`
`48`	`48`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ public WebHookDataPluginManager(IServiceProvider serviceProvider, AppOptions opt`
`12`	`12`	`/// </summary>`
`13`	`13`	`public async Task<object> CreateFromEventAsync(WebHookDataContext context)`
`14`	`14`	`{`
`15`		`- string metricPrefix = String.Concat(_metricPrefix, nameof(CreateFromEventAsync).ToLower(), ".");`
	`15`	`+ string metricPrefix = String.Concat(_metricPrefix, "ev-create", ".");`
`16`	`16`	`foreach (var plugin in Plugins.Values)`
`17`	`17`	`{`
`18`	`18`	`string metricName = String.Concat(metricPrefix, plugin.Name.ToLower());`
`@@ -42,7 +42,7 @@ public async Task<object> CreateFromEventAsync(WebHookDataContext context)`
`42`	`42`	`/// </summary>`
`43`	`43`	`public async Task<object> CreateFromStackAsync(WebHookDataContext context)`
`44`	`44`	`{`
`45`		`- string metricPrefix = String.Concat(_metricPrefix, nameof(CreateFromStackAsync).ToLower(), ".");`
	`45`	`+ string metricPrefix = String.Concat(_metricPrefix, "st-create", ".");`
`46`	`46`	`foreach (var plugin in Plugins.Values)`
`47`	`47`	`{`
`48`	`48`	`string metricName = String.Concat(metricPrefix, plugin.Name.ToLower());`