diff --git a/.github/scripts/utils.zsh/check_packages b/.github/scripts/utils.zsh/check_packages index 31f2d0f..4d0ce3d 100755 --- a/.github/scripts/utils.zsh/check_packages +++ b/.github/scripts/utils.zsh/check_packages @@ -24,16 +24,16 @@ if (( ! ${+commands[packagesbuild]} )) { pushd mkcd ${project_root:h}/obs-build-dependencies - local packages_url='http://s.sudre.free.fr/Software/files/Packages.dmg' + local packages_url='http://s.sudre.free.fr/Software/files/Packages_1210_1.dmg' local packages_hash='6afdd25386295974dad8f078b8f1e41cabebd08e72d970bf92f707c7e48b16c9' - if [[ ! -f Packages.dmg ]] { + if [[ ! -f Packages_1210_1.dmg ]] { log_status 'Download Packages.app' curl ${curl_opts} ${packages_url} } local image_checksum - read -r image_checksum _ <<< "$(sha256sum Packages.dmg)" + read -r image_checksum _ <<< "$(sha256sum Packages_1210_1.dmg)" if [[ ${packages_hash} != ${image_checksum} ]] { log_error "Checksum mismatch of Packages.app download. @@ -42,7 +42,7 @@ Actual : ${image_checksum}" return 2 } - hdiutil attach -noverify Packages.dmg &> /dev/null && log_status 'Packages.dmg image mounted.' + hdiutil attach -noverify Packages_1210_1.dmg &> /dev/null && log_status 'Packages_1210_1.dmg image mounted.' log_info 'Installing Packages.app...' packages_volume=$(hdiutil info -plist | grep '/Volumes/Packages' | sed 's/.*\(\/Volumes\/[^<]*\)<\/string>/\1/') diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0b78537..26d6235 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -266,7 +266,6 @@ jobs: path: package/* - name: "Package Installer (Prereqs)" run: | - curl "-kL" "https://github.com/Xaymar/msvc-redist-helper/releases/download/0.1/msvc-redist-helper-64.exe" "-f" "--retry" "5" "-o" "msvc-redist-helper.exe" curl "-kL" "https://files.jrsoftware.org/is/6/innosetup-6.0.3.exe" "-f" "--retry" "5" "-o" "inno.exe" .\inno.exe /VERYSILENT /SP- /SUPPRESSMSGBOXES /NORESTART - name: "Package Installer (Compile)" diff --git a/CMakeLists.txt b/CMakeLists.txt index 774d569..a421334 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,6 +1,9 @@ # --- Detect if the plugin is build out of tree or not --- if(CMAKE_PROJECT_NAME STREQUAL "obs-studio") set(BUILD_OUT_OF_TREE OFF) + if(OBS_CMAKE_VERSION VERSION_GREATER_EQUAL 3.0.0) + legacy_check() + endif() else() set(BUILD_OUT_OF_TREE ON) cmake_minimum_required(VERSION 3.18) @@ -123,9 +126,14 @@ if(BUILD_OUT_OF_TREE) LIBRARY DESTINATION ${CMAKE_INSTALL_PREFIX}/${LIB_OUT_DIR}) install(DIRECTORY data/locale DESTINATION ${CMAKE_INSTALL_PREFIX}/${DATA_OUT_DIR}) + setup_plugin_target(${PROJECT_NAME}) else() target_include_directories(${PROJECT_NAME} PRIVATE "${CMAKE_SOURCE_DIR}/UI/obs-frontend-api") - set_target_properties(${PROJECT_NAME} PROPERTIES FOLDER "plugins/exeldro") + if(OBS_CMAKE_VERSION VERSION_GREATER_EQUAL 3.0.0) + set_target_properties_obs(${PROJECT_NAME} PROPERTIES FOLDER "plugins/exeldro" PREFIX "") + else() + set_target_properties(${PROJECT_NAME} PROPERTIES FOLDER "plugins/exeldro") + setup_plugin_target(${PROJECT_NAME}) + endif() endif() -setup_plugin_target(${PROJECT_NAME}) diff --git a/installer.iss.in b/installer.iss.in index 4a9f33f..9784114 100644 --- a/installer.iss.in +++ b/installer.iss.in @@ -40,7 +40,6 @@ Name: "english"; MessagesFile: "compiler:Default.isl" [Files] Source: "package/*"; DestDir: "{app}"; Flags: ignoreversion recursesubdirs createallsubdirs -Source: "msvc-redist-helper.exe"; DestDir: "{app}"; DestName: "msvc-redist-helper.exe"; Flags: ignoreversion dontcopy noencryption ; NOTE: Don't use "Flags: ignoreversion" on any shared system files [Icons] @@ -56,7 +55,9 @@ begin Result := ExpandConstant('{pf}\obs-studio'); // query the first registry value; if this succeeds, return the obtained value if RegQueryStringValue(HKLM32, 'SOFTWARE\OBS Studio', '', InstallPath) then - Result := InstallPath + Result := InstallPath; + if RegQueryStringValue(HKLM64, 'SOFTWARE\OBS Studio', '', InstallPath) then + Result := InstallPath; end; ///////////////////////////////////////////////////////////////////// @@ -107,20 +108,12 @@ begin end; ///////////////////////////////////////////////////////////////////// -procedure CurStepChanged(CurStep: TSetupStep); -var - ResultCode: Integer; +function NextButtonClick(PageId: Integer): Boolean; begin - if (CurStep=ssInstall) then - begin - if (IsUpgrade()) then - begin - UnInstallOldVersion(); + Result := True; + if (PageId = wpSelectDir) and not FileExists(ExpandConstant('{app}\bin\64bit\obs64.exe')) then begin + MsgBox('OBS Studio (bin\64bit\obs64.exe) does not seem to be installed in that folder. Please select the correct folder.', mbError, MB_OK); + Result := False; + exit; end; - end; - if (CurStep=ssPostInstall) then - begin - ExtractTemporaryFile('msvc-redist-helper.exe'); - Exec(ExpandConstant('{tmp}\msvc-redist-helper.exe'), '2019', '', SW_HIDE, ewWaitUntilTerminated, ResultCode); - end; -end; \ No newline at end of file +end;