You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a small gap in test cases which would allow error prone code to pass the tests.
For example, there is checked 32 with empty list as the result (because it's 10_000 in binary), and it works fine for following code (returns empty list on after index == 4 check) :
` fun calculateHandshake(number: Int): List {
val action = Integer.toBinaryString(number).reversed()
val result = mutableListOf()
for((index, n) in action.withIndex()) {
if (index == 4) {
return result.reversed()
}
if (n.toString().toInt() == 1) {
result.add(Signal.values()[index])
}
}
return result
}`
Once you change test number to 33, which also should return an empty list, the list actually contains "WINK"
I propose to add one more test case to cover that little gap
The text was updated successfully, but these errors were encountered:
At Exercism we use our Community Forum, not GitHub issues, as the primary place for discussion. That allows maintainers and contributors from across Exercism's ecosystem to discuss your problems/ideas/suggestions without them having to subscribe to hundreds of repositories.
This issue will be automatically closed. Please use this link to copy your GitHub Issue into a new topic on the forum, where we look forward to chatting with you!
If you're interested in learning more about this auto-responder, please read this blog post.
There is a small gap in test cases which would allow error prone code to pass the tests.
For example, there is checked 32 with empty list as the result (because it's 10_000 in binary), and it works fine for following code (returns empty list on after index == 4 check) :
` fun calculateHandshake(number: Int): List {
val action = Integer.toBinaryString(number).reversed()
val result = mutableListOf()
Once you change test number to 33, which also should return an empty list, the list actually contains "WINK"
I propose to add one more test case to cover that little gap
The text was updated successfully, but these errors were encountered: