feat: add support to monorepo and fix varius issues #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rluvaton
changed the title
jefflward
reviewed
Jul 20, 2023
Comment on lines
+36
to
+41
| let terminalAlreadyExists = true; | ||
| if (!terminal || terminal.exitStatus) { | ||
| terminalAlreadyExists = false; | ||
| terminal?.dispose(); | ||
| terminal = vscode.window.createTerminal(`vscode-vitest-runner`); | ||
| } |
There was a problem hiding this comment.
👍🏻 hope this change is released soon. Would like this behavior.
There was a problem hiding this comment.
forked and published my own package given this is not maintained https://marketplace.visualstudio.com/items?itemName=rluvaton.vscode-vitest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that this project is not maintained anymore I've created a new extension that actually works - here
3 things this PR fixes:
Monorepo support
add support to Monorepo by looking up the nearest vitest config
inside a monorepo we have vitest config in the application folder and not the folder where the package json exists
Fix #7
React scripts fix
don't
cdto the current dir name as some places rely on the cwdlike this:
https://github.com/facebook/create-react-app/blob/0a827f69ab0d2ee3871ba9b71350031d8a81b7ae/packages/react-scripts/config/paths.js#L15-L30
it will try to read the package json in the cwd
Reuse existing terminal
this will reuse the existing terminal fix #8