Skip to content

refactor(eas-cli): use built-in Node fetch instead of undici #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: @bycedric/eas-cli/swap-node-fetch-for-undici
Choose a base branch
from
Draft

refactor(eas-cli): use built-in Node fetch instead of undici #2419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions packages/eas-cli/__mocks__/undici.ts
View file
Open in desktop

This file was deleted.

16 changes: 6 additions & 10 deletions packages/eas-cli/src/fetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
import { env } from 'node:process';
import {
ProxyAgent,
type RequestInfo,
type RequestInit,
type Response,
fetch,
getGlobalDispatcher,
setGlobalDispatcher,
} from 'undici';
import { ProxyAgent, getGlobalDispatcher, setGlobalDispatcher } from 'undici';

export { Agent, Headers, type RequestInfo, type RequestInit, Response } from 'undici';
// Re-export the fetch-related Node globals
export type RequestInfo = globalThis.RequestInfo;
export type RequestInit = globalThis.RequestInit;
export type Response = globalThis.Response;
export const Headers = globalThis.Headers;

export class RequestError extends Error {
constructor(
Expand Down