Skip to content

Let the extra_validity_checks return an error message #95

@eyalroz

Description

@eyalroz

At the moment, a kernel adapter's extra_validity_checks() method only returns a boolean; but - it is not afforded a logger to print any error messages, so, essentially, the cause of failure remains opaque.

Assuming we continue to deny the adapter access to the logger, we should instead let it return something other than a boolean, e.g. an optional<std::string> or similar object, which, when empty, means success, otherwise is an error message to print. Alternatively we could not return anything from that method, and instead let it throw.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions