Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URI schemas with dashes #378

Open
tapsavo opened this issue Jul 10, 2023 · 2 comments
Open

URI schemas with dashes #378

tapsavo opened this issue Jul 10, 2023 · 2 comments

Comments

@tapsavo
Copy link

tapsavo commented Jul 10, 2023

Having a bit of issues with htmlpurifier when it comes to links with the schemapart containing a dash, eg: "foo-bar://something/something-the-local-computer-handles-when-clicked"

This would be fairly straightforward with the URI.AllowedSchemes and writing a class for it, but a class with a dash in it's name isn't allowed in PHP. eg. in this case "HTMLPurifier_URIScheme_foo-bar".

As far as I'm aware, "+", "-"... etc are allowed by the rfc2396.
@pyres01

This comment was marked as spam.

Sign in to view
@ezyang
Copy link
Owner

ezyang commented Jul 10, 2023

bloop. Someone should write a patch to normalize the schemes to be valid class name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ezyang @tapsavo @pyres01