Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate .from_inner2 from StructuredMatrix interface #37

Open
f-dangel opened this issue Oct 26, 2023 · 0 comments · May be fixed by #38
Open

Deprecate .from_inner2 from StructuredMatrix interface #37

f-dangel opened this issue Oct 26, 2023 · 0 comments · May be fixed by #38
Labels
discussion enhancement New feature or request

Comments

@f-dangel
Copy link
Owner

We originally incorporated this function to support updates based K.T @ (a @ a.T) @ K and K.T @ (g @ g.T) @ K, e.g. in the private ASDL implementation.

But now we are using an update that computes (K.T @ a) (K.T @ a).T and (K.T @ g) @ (K.T @ g).T instead via StructuredMatrix.from_inner. Hence, we can remove from_inner2 and the associated tests.
@f-dangel f-dangel added the enhancement New feature or request label Oct 26, 2023
@f-dangel f-dangel assigned f-dangel and unassigned f-dangel Oct 26, 2023
@f-dangel f-dangel changed the title [DEL] Deprecate .from_inner2 from StructuredMatrix interface Deprecate .from_inner2 from StructuredMatrix interface Oct 26, 2023
@f-dangel f-dangel linked a pull request Oct 26, 2023 that will close this issue
Draft
@f-dangel f-dangel self-assigned this Oct 27, 2023
@f-dangel f-dangel removed their assignment Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DEL] Remove .from_inner2 f-dangel/singd
1 participant
@f-dangel