Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Updated entities after Currency entity #26

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

koreanMike513
Copy link
Collaborator

말씀하신대로

  • Voucher entity

    • 기존의 percentages 에서 discountRate로 이름을 변경하고 혹시 몰라 comment도 달아 놓았습니다.
    • 또 scale 이나 그 밑의 값을 처리하는 전략에 대해서는 데이터베이스에서 정의하는 대로 갈 수 있게 apply() 메서드를 고쳣습니다.
  • 그 외에 다른 entity들에서는 Voucher entity의 변화 이후의 변경 사항과 annotation 및 import statement 변경 및 앞의 변경 사항으로 인한 OrderService의 변경까지 진행하였습니다.

- added Currency to Food entity
- added currency parameter to the apply() method in Voucher
- updated Order entity's apply() method
- updated Payment entity's annotations and import statements
- updated OrderService after changes
@koreanMike513 koreanMike513 added the enhancement New feature or request label Dec 29, 2024
@koreanMike513 koreanMike513 self-assigned this Dec 29, 2024
@koreanMike513 koreanMike513 merged commit 0915791 into feature/add-currency-entity Jan 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants