feat: Added FoodRepositoryFacade #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added FoodRepositoryFacade that handles RETRY logic on the food locks
f-lab-troy
approved these changes
Jan 7, 2025
| @Slf4j | ||
| @Component | ||
| @RequiredArgsConstructor | ||
| public class FoodRepositoryFacade { |
There was a problem hiding this comment.
Facade 외에 AOP를 사용하여 재시도 구현시 장단점을 비교 해보는 것을 추천드립니다.
There was a problem hiding this comment.
우선 기존의 facade를 대신하여 AOP를 사용하면
장점
- 확장성 (기존의 코드를 변경하지 않아도 된다. facade 패턴을 적용했을 때 OrderService의 의존성을 변경해주어야 하는 문제가 있었습니다)
- 선언적 annotation으로 쉽게 선언 및 적용 가능
단점
- 런타임에 동작하기 때문에 정확한 디버깅이 어려울 수 있다.
- 각 annotation의 의미를 잘 알아야 하기 때문에 learning curve가 높을 수 있다.
정도로 생각되어집니다.
koreanMike513
added
the
partially_resolved (requires a another review)
f-lab-troy
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
facade 계층을 하나 추가하여 락을 획득하는 RETRY 로직을 구현하였습니다.
그 후 테스트를 통해 정상적으로 동작하는 것을 확인하고 OrderService 내의 foodRepository 를 foodRepositoryFacade로 교체하였습니다.