Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving from aspect-build to f0rmiga broke builds #165

Open
chiphogg opened this issue Mar 7, 2024 · 4 comments
Open

Moving from aspect-build to f0rmiga broke builds #165

chiphogg opened this issue Mar 7, 2024 · 4 comments
Labels
untriaged Requires traige

Comments

@chiphogg
Copy link

chiphogg commented Mar 7, 2024

This move affected the stripped prefix of the automatically generated archive files, which therefore also changes the SHA. End users will need to migrate their builds by updating both the sha256 and strip_prefix fields (and updating urls too couldn't hurt).

Here's an example.
@github-actions github-actions bot added the untriaged Requires traige label Mar 7, 2024
@chiphogg
Copy link
Author

chiphogg commented Mar 7, 2024

By the way, while I'm at it, and for my own curiosity --- when did this repo move to a new home, and why?

@f0rmiga
Copy link
Owner

f0rmiga commented Apr 26, 2024

I am the original author and maintainer. Aspect donated this project to me.

@alexeagle
Copy link
Contributor

This wouldn't break you if you used GitHub's archive, which has only the repo name included but not the org.
https://github.com/f0rmiga/gcc-toolchain/archive/ac745d4685e2095cc4f057862800f3f0a473c201.tar.gz for example. The URL format you've used to fetch from GitHub is new to me, and certainly more brittle in this regard.

chiphogg added a commit to aurora-opensource/au that referenced this issue Aug 15, 2024
@chiphogg
Fetch gcc toolchain from archive/ URL
5f6e1f9 
Previously, we were using the `tarball/` URL, which includes both the
organization and the repo name as part of the prefix.  GitHub also has
an `archive/` URL format which, according to this [comment], only
includes the repo name, not the organization!

This PR switches to the new format, making us less vulnerable to build
breakage if the repo changes homes again.  (Notice how `f0rmiga` never
appears except in the URL --- in particular, it is now absent from
`strip_prefix`.)  The even better solution would be to download stable
tarballs from the release page, but the project has not yet begun to
provide those.

[comment]: f0rmiga/gcc-toolchain#165 (comment)
@chiphogg chiphogg mentioned this issue Aug 15, 2024
Merged
@chiphogg
Copy link
Author

Thank you @alexeagle for that fantastically useful comment! I wasn't aware of that. I'm going to switch to use that format instead while we wait for the more robust solution of #166.

chiphogg added a commit to aurora-opensource/au that referenced this issue Aug 15, 2024
@chiphogg
Fetch gcc toolchain from archive/ URL (#287)
d360717 
Previously, we were using the `tarball/` URL, which includes both the
organization and the repo name as part of the prefix.  GitHub also has
an `archive/` URL format which, according to this [comment], only
includes the repo name, not the organization!

This PR switches to the new format, making us less vulnerable to build
breakage if the repo changes homes again.  (Notice how `f0rmiga` never
appears except in the URL --- in particular, it is now absent from
`strip_prefix`.)  The even better solution would be to download stable
tarballs from the release page, but the project has not yet begun to
provide those.

[comment]:
f0rmiga/gcc-toolchain#165 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
untriaged Requires traige
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexeagle @chiphogg @f0rmiga