Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated methods don't warn with DeprecationWarning #293

Open
nbastin opened this issue Mar 17, 2024 · 2 comments · Fixed by #306
Open

Deprecated methods don't warn with DeprecationWarning #293

nbastin opened this issue Mar 17, 2024 · 2 comments · Fixed by #306
Assignees
@sajith

Comments

@nbastin
Copy link

nbastin commented Mar 17, 2024

It turns out there are a lot of methods in node and interface (and probably other places) that have docstrings that claim they are deprecated, but they don't issue a DeprecationWarning so downstream users are much more likely to be surprised when they are ultimately removed.
@sajith sajith self-assigned this Apr 9, 2024
@sajith sajith mentioned this issue Apr 12, 2024
Merged
@kthare10 kthare10 reopened this Apr 14, 2024
@kthare10
Copy link
Collaborator

Please check the usage of deprecated functions in fablib code.
Screenshot 2024-04-14 at 10 30 48 AM

@sajith
Copy link
Member

sajith commented Apr 15, 2024

Oh man, I declared victory too soon. Thanks @kthare10!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sajith sajith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add some deprecation warnings fabric-testbed/fabrictestbed-extensions
3 participants
@sajith @nbastin @kthare10