Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication Boo Boo #37

Open
charlielafosse opened this issue Feb 18, 2019 · 0 comments
Open

Authentication Boo Boo #37

charlielafosse opened this issue Feb 18, 2019 · 0 comments

Comments

@charlielafosse
Copy link
Contributor

As @Oliversw pointed out this morning, our authentication methods are actually pretty shaky.

Whether protected pages are rendered is just dependent on a boolean value in our state (which is updated after checking the login details against the Airtable API).

All it takes to access these pages, therefore, is just switching isAuthenticated to true in React dev tools 😱 😱

We're now researching how to remedy this. Likely gonna need JWT, bcrypt etc.! Also looking into auth0.

Article: https://medium.com/@romanchvalbo/how-i-set-up-react-and-node-with-json-web-token-for-authentication-259ec1a90352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants