Move the vector when setting ResourceData

Utku Gürkan · facebook-github-bot · commit 0ba72ed46968 · 2024-12-12T16:28:12.000-08:00
Summary: This was probably missed; just caught my eye while reading some code

Reviewed By: hanidamlaj

Differential Revision: D66898519

fbshipit-source-id: 6f66acabe4792b942dc578221dee27bd5044f6a7
diff --git a/proxygen/lib/stats/ResourceData.h b/proxygen/lib/stats/ResourceData.h
@@ -339,7 +339,7 @@ struct ResourceData : public PeriodicStatsDataBase {
     cpuUtilPercentileConfigured_ = cpuUtilPercentileConfigured;
     cpuRatioUtilPercentile_ = cpuRatioUtilPercentile;
     cpuSoftIrqRatioUtil_ = cpuSoftIrqUsageRatio;
-    softIrqCpuCoreRatioUtils_ = softIrqCpuCoreRatioUtils;
+    softIrqCpuCoreRatioUtils_ = std::move(softIrqCpuCoreRatioUtils);
   }
 
   void setMemStats(uint64_t usedMemBytes,

Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,7 @@ struct ResourceData : public PeriodicStatsDataBase {`
`339`	`339`	`cpuUtilPercentileConfigured_ = cpuUtilPercentileConfigured;`
`340`	`340`	`cpuRatioUtilPercentile_ = cpuRatioUtilPercentile;`
`341`	`341`	`cpuSoftIrqRatioUtil_ = cpuSoftIrqUsageRatio;`
`342`		`- softIrqCpuCoreRatioUtils_ = softIrqCpuCoreRatioUtils;`
	`342`	`+ softIrqCpuCoreRatioUtils_ = std::move(softIrqCpuCoreRatioUtils);`
`343`	`343`	`}`
`344`	`344`
`345`	`345`	`void setMemStats(uint64_t usedMemBytes,`