Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sapling PR bodies are formatted incorrectly on GitHub #978

Open
poteto opened this issue Oct 29, 2024 · 1 comment
Open

Sapling PR bodies are formatted incorrectly on GitHub #978

poteto opened this issue Oct 29, 2024 · 1 comment

Comments

@poteto
Copy link
Member

poteto commented Oct 29, 2024

I have noticed that Sapling (via ISL) is stripping trailing new lines in my commit body. This isn't a major functional problem, but on GitHub because of markdown formatting, the last sentence in the body becomes a heading due to the --- immediately after it. This makes the PR body look quite comical (eg look at facebook/react#31384 prior to my edit) since the whole thing becomes an H2.

You can work around this by adding any non-whitespace character to the end of your description, or manually editing your PR description after it's opened, but it'd be better if Sapling just didn't strip trailing whitespace in commit bodies to begin with.

@smart-tech-master
Copy link

Hi Poteto
Do you have a solution about this issue on your mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants