Slots overflow and tracers dependency fix

aandreyeu · facebook-github-bot · commit efb16786c081 · 2022-01-19T18:17:27.000-08:00
Reviewed By: yukonfb

Differential Revision: D33540591

fbshipit-source-id: 2d114ce15c9a200579c5541f677420cd6548b057
diff --git a/cpp/profiler/SamplingProfiler.cpp b/cpp/profiler/SamplingProfiler.cpp
@@ -222,7 +222,6 @@ void SamplingProfiler::UnwindStackHandler(
       if (nextSlotState != StackSlotState::FREE) {
         profiler.maybeSignalReader();
       }
-      continue;
     } else {
       // We came from the longjmp in sigcatch_handler.
       // Something must have crashed.
@@ -235,7 +234,7 @@ void SamplingProfiler::UnwindStackHandler(
         abortWithReason(
             "Invariant violation - BUSY_WITH_METADATA to SIGNAL_INTERRUPT failed");
       }
-      break;
+      profiler.maybeSignalReader();
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,6 @@ void SamplingProfiler::UnwindStackHandler(`
`222`	`222`	`if (nextSlotState != StackSlotState::FREE) {`
`223`	`223`	`profiler.maybeSignalReader();`
`224`	`224`	`}`
`225`		`- continue;`
`226`	`225`	`} else {`
`227`	`226`	`// We came from the longjmp in sigcatch_handler.`
`228`	`227`	`// Something must have crashed.`
`@@ -235,7 +234,7 @@ void SamplingProfiler::UnwindStackHandler(`
`235`	`234`	`abortWithReason(`
`236`	`235`	`"Invariant violation - BUSY_WITH_METADATA to SIGNAL_INTERRUPT failed");`
`237`	`236`	`}`
`238`		`- break;`
	`237`	`+ profiler.maybeSignalReader();`
`239`	`238`	`}`
`240`	`239`	`}`
`241`	`240`	`}`