Skip to content

Commit 1f044c3

Browse files
aavbsouzafacebook-github-bot
authored andcommitted
remove template specification (#36)
Summary: # PR Details fix compilation error with gcc 14 (Fedora 40) ## Description Remove template specification to avoid error `error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]` ## Related Issue #35 ## Motivation and Context Pull Request resolved: #36 Test Plan: I've compiled the code with the g++ from ubuntu 20.04, 22.04 and 24.04 docker images and g++ from Fedora 40 and executed the tests with success except for the test Priorty.PriorityGetsCycles ## Types of changes - [ ] Docs change - [ ] Refactoring - [ ] Dependency upgrade - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist - [x] My code follows the code style of this project. - [x] I have run clang-format. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [x] I have read the **CONTRIBUTING** document. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed, including in ASAN and TSAN modes (if available on your platform). Reviewed By: RomanFedotovFB Differential Revision: D62474193 Pulled By: graphicsMan fbshipit-source-id: 34a27756774d25f85a8d6cdd54397c3a33627072
1 parent 6ef636a commit 1f044c3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

dispenso/graph.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -486,7 +486,7 @@ class DISPENSO_DLL_ACCESS SubgraphT {
486486

487487
static constexpr size_t kNodeSizeP2 = detail::nextPow2(sizeof(NodeType));
488488

489-
explicit SubgraphT<N>(GraphT<N>* graph) : graph_(graph), nodes_(), allocator_(getAllocator()) {}
489+
explicit SubgraphT(GraphT<N>* graph) : graph_(graph), nodes_(), allocator_(getAllocator()) {}
490490

491491
inline void removeNodeFromBiPropSet(Node* /* node */) {}
492492
void removeNodeFromBiPropSet(BiPropNode* node) {
@@ -527,7 +527,7 @@ class DISPENSO_DLL_ACCESS GraphT {
527527
/**
528528
* Create empty graph.
529529
**/
530-
GraphT<N>() {
530+
GraphT() {
531531
subgraphs_.push_back(SubgraphType(this));
532532
}
533533
/**

0 commit comments

Comments
 (0)