Skip to content

Commit 5771bad

Browse files
graphicsManfacebook-github-bot
authored andcommitted
Disable last test with NewThreadInvoker usage
Summary: Windows does not seem to play by the rules with atexit, leaving NewThreadInvoker cleanup not working portably. Some future work will be done to make cleanup work portably, but for now, disable the last remaining test using NewThreadInvoker. Reviewed By: elliotsegal-fb Differential Revision: D55806373 fbshipit-source-id: 8a7734ac7ec7eb8a0b47da8723870f00fba138da
1 parent 9867f5f commit 5771bad

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/future_test.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ TEST(Future, ImmediateInvoker) {
655655
EXPECT_EQ(7, val);
656656
}
657657

658-
TEST(Future, NewThreadInvoker) {
658+
TEST(Future, DISABLED_NewThreadInvoker) {
659659
// Nearly always it should be better to use async/ThreadPool/TaskSet, but there may be occasions
660660
// where you actually want the work done on a new thread.
661661
dispenso::Future<int> future([]() { return 333; }, dispenso::kNewThreadInvoker);

0 commit comments

Comments
 (0)