From 0aca0578ea8f917edcf4c6c1de08013038b4aed5 Mon Sep 17 00:00:00 2001
From: Piotr Chmiel <piotr.chmiel@hotmail.com>
Date: Mon, 22 Jan 2024 20:27:48 +0000
Subject: [PATCH] Changing the count parameter type from int to size_t in
 reduction algorithms.

---
 gloo/allreduce_bcube.h            | 6 +++---
 gloo/allreduce_halving_doubling.h | 6 +++---
 gloo/allreduce_local.cc           | 2 +-
 gloo/allreduce_local.h            | 6 +++---
 gloo/allreduce_ring.h             | 6 +++---
 gloo/allreduce_ring_chunked.h     | 6 +++---
 6 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/gloo/allreduce_bcube.h b/gloo/allreduce_bcube.h
index f7b7e02ab..25d4eb5f5 100644
--- a/gloo/allreduce_bcube.h
+++ b/gloo/allreduce_bcube.h
@@ -258,7 +258,7 @@ class AllreduceBcube : public Algorithm {
   AllreduceBcube(
       const std::shared_ptr<Context>& context,
       const std::vector<T*> ptrs,
-      const int count,
+      const size_t count,
       const ReductionFunction<T>* fn = ReductionFunction<T>::sum)
       : Algorithm(context),
         myRank_(this->context_->rank),
@@ -461,11 +461,11 @@ class AllreduceBcube : public Algorithm {
   /**
    * Total number of elements to process
    */
-  const int totalNumElems_{0};
+  const size_t totalNumElems_{0};
   /**
    * Total number of bytes to process
    */
-  const int bytes_{0};
+  const size_t bytes_{0};
   /**
    * Total number of steps
    */
diff --git a/gloo/allreduce_halving_doubling.h b/gloo/allreduce_halving_doubling.h
index 7392d1f93..c5d11f692 100644
--- a/gloo/allreduce_halving_doubling.h
+++ b/gloo/allreduce_halving_doubling.h
@@ -67,7 +67,7 @@ class AllreduceHalvingDoubling : public Algorithm {
   AllreduceHalvingDoubling(
       const std::shared_ptr<Context>& context,
       const std::vector<T*> ptrs,
-      const int count,
+      const size_t count,
       const ReductionFunction<T>* fn = ReductionFunction<T>::sum)
       : Algorithm(context),
         ptrs_(ptrs),
@@ -362,8 +362,8 @@ class AllreduceHalvingDoubling : public Algorithm {
 
  protected:
   std::vector<T*> ptrs_;
-  const int count_;
-  const int bytes_;
+  const size_t count_;
+  const size_t bytes_;
   const size_t steps_;
   const size_t chunks_;
   const size_t chunkSize_;
diff --git a/gloo/allreduce_local.cc b/gloo/allreduce_local.cc
index 54a195a8d..7188fab21 100644
--- a/gloo/allreduce_local.cc
+++ b/gloo/allreduce_local.cc
@@ -16,7 +16,7 @@ template <typename T>
 AllreduceLocal<T>::AllreduceLocal(
     const std::shared_ptr<Context>& context,
     const std::vector<T*>& ptrs,
-    const int count,
+    const size_t count,
     const ReductionFunction<T>* fn)
     : Algorithm(context),
       ptrs_(ptrs),
diff --git a/gloo/allreduce_local.h b/gloo/allreduce_local.h
index ed2285da4..79e70c960 100644
--- a/gloo/allreduce_local.h
+++ b/gloo/allreduce_local.h
@@ -19,7 +19,7 @@ class AllreduceLocal : public Algorithm {
   AllreduceLocal(
       const std::shared_ptr<Context>& context,
       const std::vector<T*>& ptrs,
-      const int count,
+      const size_t count,
       const ReductionFunction<T>* fn = ReductionFunction<T>::sum);
 
   virtual ~AllreduceLocal() = default;
@@ -28,8 +28,8 @@ class AllreduceLocal : public Algorithm {
 
  protected:
   std::vector<T*> ptrs_;
-  const int count_;
-  const int bytes_;
+  const size_t count_;
+  const size_t bytes_;
   const ReductionFunction<T>* fn_;
 };
 
diff --git a/gloo/allreduce_ring.h b/gloo/allreduce_ring.h
index 275fd33d9..7619e6f6c 100644
--- a/gloo/allreduce_ring.h
+++ b/gloo/allreduce_ring.h
@@ -22,7 +22,7 @@ class AllreduceRing : public Algorithm {
   AllreduceRing(
       const std::shared_ptr<Context>& context,
       const std::vector<T*>& ptrs,
-      const int count,
+      const size_t count,
       const ReductionFunction<T>* fn = ReductionFunction<T>::sum)
       : Algorithm(context),
         ptrs_(ptrs),
@@ -114,8 +114,8 @@ class AllreduceRing : public Algorithm {
 
  protected:
   std::vector<T*> ptrs_;
-  const int count_;
-  const int bytes_;
+  const size_t count_;
+  const size_t bytes_;
   const ReductionFunction<T>* fn_;
 
   T* inbox_;
diff --git a/gloo/allreduce_ring_chunked.h b/gloo/allreduce_ring_chunked.h
index 1c627583a..f9af0db99 100644
--- a/gloo/allreduce_ring_chunked.h
+++ b/gloo/allreduce_ring_chunked.h
@@ -22,7 +22,7 @@ class AllreduceRingChunked : public Algorithm {
   AllreduceRingChunked(
       const std::shared_ptr<Context>& context,
       const std::vector<T*>& ptrs,
-      const int count,
+      const size_t count,
       const ReductionFunction<T>* fn = ReductionFunction<T>::sum)
       : Algorithm(context),
         ptrs_(ptrs),
@@ -236,8 +236,8 @@ class AllreduceRingChunked : public Algorithm {
   }
 
   std::vector<T*> ptrs_;
-  const int count_;
-  const int bytes_;
+  const size_t count_;
+  const size_t bytes_;
   const ReductionFunction<T>* fn_;
 
   size_t chunks_;