Mephisto metrics + docker integration misaligned

[JackUrb]

Overview

Mephisto metrics is currently not working correctly for docker-based installs of Mephisto. A potential solution has been outlined below, though there's a little exploration to be done first. The final steps for resolving are:

• Implement steps (1) and (2) of the proposal.
• Figure out why the resources files aren't available inside of the mounted docker image
• Resolve the resources issue after diagnosing.

[pringshia]

Did some more digging and it seems that $OSTYPE is not detected by sh which is what the mephisto metrics install command uses, we should use bash instead.

Debug steps

First enter the docker container:

$ docker build -t mephisto .
$ docker run -it --rm -p 3000:3000 mephisto sh -c "echo \$OSTYPE" # empty output

$ docker run -it --rm -p 3000:3000 mephisto bash -c "echo \$OSTYPE" # correct output
linux-gnu

More verification. Since we use sh to invoke the install script, we never get $OSTYPE to resolve and hit the default case for the switch statement here.

$ sh mephisto/scripts/metrics/install_metrics.sh
Unable to automate install for

---

With bash:

$ bash mephisto/scripts/metrics/install_metrics.sh

# Now it runs as expected

Proposal

1. Use bash instead of sh here
2. Install curl into the Docker image, which mephisto metrics install depends on (and optionally vim - useful for debugging in the image)

   RUN apt-get update && apt-get -y install curl vim
   

3. Figure out why this error still comes up after running mephisto metrics install:

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 70.6M  100 70.6M    0     0  10.1M      0  0:00:06  0:00:06 --:--:-- 13.4M
cp: cannot stat 'resources/grafana_defaults.ini': No such file or directory
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   671  100   671    0     0   3022      0 --:--:-- --:--:-- --:--:--  3022
100 72.3M  100 72.3M    0     0  6729k      0  0:00:11  0:00:11 --:--:-- 8749k
cp: cannot stat 'resources/mephisto-prometheus-config.yml': No such file or directory
..........................................................................................................................................................................................................................

[JackUrb]

The proposal here sounds good to me! For part 3 though, I'd guess that somehow the docker container is dropping the contents of the resources/ directory due to .dockerignore not following the ! exclude setup that .gitignore does.

[pringshia]

Hmm, ! should work with the .dockerignore...

Lines starting with ! (exclamation mark) can be used to make exceptions to exclusions. The following is an example .dockerignore file that uses this mechanism:

https://docs.docker.com/engine/reference/builder/#dockerignore-file