Skip to content

Commit c3c60b2

Browse files
committed
Bug fix for _ & spaces
1 parent 6ed6ced commit c3c60b2

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

spot_rl_experiments/spot_rl/utils/cg_waypoint_recorder.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,9 @@ def add_furniture(self, furniture_name: str):
219219
new_furniture_relation = {
220220
"object1": {
221221
"id": new_entity_id,
222-
"object_tag": furniture_name,
222+
"object_tag": furniture_name.replace(
223+
"_", " "
224+
), # we should not have '_'s inside object_tags
223225
"bbox_extent": [0.5, 0.5, place_target[2] / 2.0],
224226
"bbox_center": [
225227
place_target[0],

spot_rl_experiments/spot_rl/utils/skill_executor.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -374,15 +374,16 @@ def execute_skills(self): # noqa: C901
374374
bbox_extent = np.array([float(v) for v in bbox_info[3:6]])
375375

376376
if ":" in bbox_info[6]:
377-
query_class_names = bbox_info[6].split(":")[1]
378-
query_class_names = query_class_names.split("_")
379-
if query_class_names[0].isdigit():
380-
query_class_names = ["_".join(query_class_names[1:])]
381-
else:
382-
query_class_names = ["_".join(query_class_names)]
377+
query_class_names = bbox_info[6].split(":")[1] # For exploration
383378
else:
384-
query_class_names = bbox_info[6:]
385-
query_class_names[0] = query_class_names[0].replace("_", " ")
379+
query_class_names = bbox_info[6] # For nav with view poses
380+
381+
# Strip id from query_class_name
382+
query_class_names = query_class_names.split("_")
383+
if query_class_names[0].isdigit():
384+
query_class_names = [" ".join(query_class_names[1:])]
385+
else:
386+
query_class_names = [" ".join(query_class_names)]
386387

387388
if robot_holding:
388389
rospy.set_param("/viz_place", query_class_names[0])

0 commit comments

Comments
 (0)