Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup release-it + changelog plugin #1096

Closed
Shinigami92 opened this issue Jun 20, 2022 · 3 comments
Closed

Setup release-it + changelog plugin #1096

Shinigami92 opened this issue Jun 20, 2022 · 3 comments
Assignees
@Shinigami92
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Milestone
vAnytime

Comments

@Shinigami92
Copy link
Member

Replace https://github.com/conventional-changelog/standard-version with https://github.com/changesets/changesets

standard-version is deprecated and not maintained anymore: see https://www.npmjs.com/package/standard-version
The author suggests to use https://github.com/googleapis/release-please
We could look into that, but I would suggest to have a look into changesets as it is used by pnpm

As changing the release process might produce a different style of CHANGELOG.md, I would prefer to make the move to a new release workflow in a major update of Faker.

changesets can definitely handle mono-repos and maybe someday we want to convert this repo to a monorepo, so when suggesting alternative tools or workflows, keep this in mind.

related to #268
@Shinigami92 Shinigami92 added c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release labels Jun 20, 2022
@Shinigami92 Shinigami92 added this to the vFuture milestone Jun 20, 2022
@Shinigami92 Shinigami92 self-assigned this Jun 20, 2022
@Shinigami92 Shinigami92 moved this to Todo in Faker Roadmap Jun 20, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Jun 20, 2022

See also #942

@Shinigami92 Shinigami92 mentioned this issue Aug 26, 2022
Merged
@Shinigami92
Copy link
Member Author

Today I will try https://github.com/release-it/release-it with some of my personal repos

@Shinigami92 Shinigami92 changed the title Replace standard-version with changesets Replace standard-version with alternative Oct 7, 2022
@Shinigami92 Shinigami92 changed the title Replace standard-version with alternative Setup release-it + changelog plugin Oct 13, 2022
@Shinigami92 Shinigami92 linked a pull request Oct 15, 2022 that will close this issue
infra: setup release-it #1455
Closed
@Shinigami92 Shinigami92 mentioned this issue Oct 15, 2022
Closed
@Shinigami92 Shinigami92 moved this from Todo to In Progress in Faker Roadmap Oct 15, 2022
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup and removed c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release labels Oct 15, 2022
@ejcheng ejcheng mentioned this issue Jan 26, 2023
Closed
@ST-DDT
Copy link
Member

ST-DDT commented Apr 13, 2023

Team Decision

We don't need this for v8.0.
(We will likely immediately start with v9 after v8.0)

@ST-DDT ST-DDT modified the milestones: v8.x, vAnytime Oct 10, 2023
@ST-DDT ST-DDT closed this as completed Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shinigami92 Shinigami92

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: In Progress
Milestone
vAnytime
Development

Successfully merging a pull request may close this issue.

infra: setup release-it faker-js/faker
2 participants
@ST-DDT @Shinigami92