Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching unique on website suggests page that does not exist #2267

Closed
drozd-A opened this issue Jul 20, 2023 · 11 comments · Fixed by #2513
Closed

Searching unique on website suggests page that does not exist #2267

drozd-A opened this issue Jul 20, 2023 · 11 comments · Fixed by #2513
Assignees
Labels
c: bug Something isn't working c: docs Improvements or additions to documentation p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug
Milestone

Comments

@drozd-A
Copy link

drozd-A commented Jul 20, 2023

When searching for "unique" on https://fakerjs.dev/, a suggestion is provided that seems to suggest there's a documentation page called "Unique". When I click on this suggestion, it takes me to the 404 page.

Screen.Recording.2023-07-20.at.1.14.57.PM.mov
@ST-DDT ST-DDT added c: bug Something isn't working c: docs Improvements or additions to documentation labels Jul 20, 2023
@xDivisionByZerox
Copy link
Member

I can confirm that this bug exists 👍

@ST-DDT
Copy link
Member

ST-DDT commented Jul 20, 2023

I tried to fix the error, but the new faker.helpers.unique method doesn't show up.

@ST-DDT
Copy link
Member

ST-DDT commented Sep 21, 2023

The bug still exists. Should we just remove the search or is there anybody that would like to investigate this?

@ST-DDT ST-DDT added the p: 2-high Fix main branch label Sep 21, 2023
@matthewmayer
Copy link
Contributor

So this uses a third party search right https://github.com/algolia/algoliasearch-client-javascript

How does it work, does it provide any way like a web dashboard to configure it and inspect your search index?

@ST-DDT
Copy link
Member

ST-DDT commented Sep 22, 2023

Yes, we already removed the unique from there but it seems to be back.
I assume that either the next or v7/v6 branches bleed into the main side search index wise.

@matthewmayer
Copy link
Contributor

How does Algolia get the data? Does it scrape the public web? Can you specify which domains and subdomains it scrapes?

@matthewmayer
Copy link
Contributor

The search index in general seems outdated. For example if you search for fullname it returns the old name module not person.

@ST-DDT
Copy link
Member

ST-DDT commented Sep 28, 2023

Well, if you search for iban (which is new), it shows that as well. So its more of a pollution than being outdated.

@matthewmayer
Copy link
Contributor

iban has been there since 4.0.0

isbn is new and doesn't appear in search.

@ST-DDT
Copy link
Member

ST-DDT commented Sep 29, 2023

Ups 😳 . Mental typo.

@ST-DDT
Copy link
Member

ST-DDT commented Oct 10, 2023

Team decision

  • Create search index per major version + next

@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Oct 10, 2023
@ST-DDT ST-DDT self-assigned this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working c: docs Improvements or additions to documentation p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants