Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pejorative Expression in Hungarian locale #2575

Closed
dev-el-op opened this issue Dec 11, 2023 · 9 comments · Fixed by #2816
Closed

Pejorative Expression in Hungarian locale #2575

dev-el-op opened this issue Dec 11, 2023 · 9 comments · Fixed by #2816
Assignees
@ST-DDT
Labels
c: locale Permutes locale definitions m: word Something is referring to the word module p: 1-normal Nothing urgent
Milestone
vAnytime

Comments

@dev-el-op
Copy link

I found a pejorative expression among the Hungarian adopted words. In line 8173 of the /src/locales/hu/word/noun.ts file, the word means b*tch in Hungarian. One of our testers noticed it when in a literal translation the web address of one of the example sales locations became https://unbred-b*tch.com/ in Hungarian.
@dev-el-op
Copy link
Author

Okey, now i found like 15 of them in the same file 😅

@matthewmayer
Copy link
Contributor

Yes these should be removed (we did this for English in #1631 )

Would you be able to make a PR for removing any offensive vocabulary in hu locale?

@matthewmayer matthewmayer added c: locale Permutes locale definitions m: word Something is referring to the word module labels Dec 11, 2023
@dev-el-op
Copy link
Author

Absolutely, I can take care of removing any offensive vocabulary in the Hungarian locale. I'll aim to submit a pull request for this task within this week.

@ST-DDT ST-DDT added this to the vAnytime milestone Dec 11, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Dec 11, 2023

I also noticed, that the file is huge with 10620 lines. We should reduce that to 1000 entries (not sure though whether it should be in a separate PR for the pejorative expression removal).

@ejcheng
Copy link
Member

ejcheng commented Dec 13, 2023

I also noticed, that the file is huge with 10620 lines. We should reduce that to 1000 entries (not sure though whether it should be in a separate PR for the pejorative expression removal).

I think separating the PRs would be better--- remove the pejorative expressions first, then reduce to 1000 entries.

@matthewmayer
Copy link
Contributor

Might be better to reduce to 1000 first, then less hunting is required for the pejorative expressions!

@ST-DDT
Copy link
Member

ST-DDT commented Feb 24, 2024

@dev-el-op Do you have time to create a PR that removes those expressions?

@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Feb 24, 2024
@ST-DDT
Copy link
Member

ST-DDT commented Mar 4, 2024

@dev-el-op Any idea when you have time for this?

@ST-DDT ST-DDT mentioned this issue Apr 13, 2024
Merged
@ST-DDT ST-DDT assigned ST-DDT and unassigned dev-el-op Apr 13, 2024
@ST-DDT
Copy link
Member

ST-DDT commented Apr 13, 2024

I created #2816 to hopefully remove all offending words.

If there are other offending words please tell me.
Otherwise we have to do that in a future PR.

@ST-DDT ST-DDT changed the title Pejorative Expression Pejorative Expression in Hungarian locale Apr 13, 2024
@xDivisionByZerox xDivisionByZerox mentioned this issue May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ST-DDT ST-DDT

Labels
c: locale Permutes locale definitions m: word Something is referring to the word module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging a pull request may close this issue.

fix(locale): clean up Hungarian words faker-js/faker
4 participants
@matthewmayer @ST-DDT @ejcheng @dev-el-op