-
-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for generating Roman Numerals #2649
Comments
Thank you for your feature proposal. We marked it as "waiting for user interest" for now to gather some feedback from our community:
We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements. We will start the implementation based on:
We do this because:
|
Would indeed be interesting at times to have this. I personally see no need for numerals above 4999 or lowercases ones. Min/max is indeed good to have. |
Should i implement this feature ? |
We normally wait until a feature has 10 GitHub upvotes. It's nearly there 😀 |
@AmaanRS Do you need roman numerals by string length (range) or by value range? |
Yes, I need it by value range (eg: from 1 to 100) |
@AmaanRS Could you please describe your usecase? What will you use the output of the method for? |
I have to number the recipe in cookbook by roman numbers, and for that function i am writing tests, which needs random roman numbers |
So..., should i create it ? |
Since there are now 10 upvotes, I think you could go ahead and start working on it to aid with discussion. Be sure to read the Contributing guide for advice. Be aware it will likely take some time to review and merge as the maintainers are busy getting v9 ready for release. |
So should i create a function named convertToRomanNumerals or a function on the property number named romanNumeral |
Please create a function in the number module, so that you can call it like this: faker.number.romanNumerals() |
Maybe singular romanNumeral rather than plural romanNumerals |
Clear and concise description of the problem
It would be useful to be able to generate roman numerals, e.g. for sections of a fake document, or as a fake pattern to be used in another pattern like "Super Bowl XXVII".
Suggested solution
min would default to 1 (you can't write 0 in roman numerals). max would probably be limited to 4999 as roman numerals are not as well-defined above 5000.
Maybe lowercase/uppercase options?
Not localizable. Since roman numerals are always written in latin script.
Alternative
write custom conversion code eg.
where convertToRomanNumerals is a suitable implementation from https://stackoverflow.com/questions/9083037/convert-a-number-into-a-roman-numeral-in-javascript
Additional context
No response
The text was updated successfully, but these errors were encountered: