Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use accents in en country names #3264

Open
matthewmayer opened this issue Nov 14, 2024 · 1 comment
Open

Use accents in en country names #3264

matthewmayer opened this issue Nov 14, 2024 · 1 comment
Assignees
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Milestone

Comments

@matthewmayer
Copy link
Contributor

Currently country definitions only use ASCII

However a few countries are typically written with diacritics even in English, specifically

  1. Aland Islands - Should be Åland Islands.
    2. Cote d’Ivoire - Should be Côte d’Ivoire.
    3. Curacao - Should be Curaçao.
    4. Reunion - Should be Réunion.
    5. Saint Barthelemy - Should be Saint Barthélemy.

I think including the accents is more likely to be helpful in rooting out bugs in code that wrongly assumes ASCII.

@matthewmayer matthewmayer self-assigned this Nov 14, 2024
@matthewmayer matthewmayer added c: locale Permutes locale definitions m: location Something is referring to the location module labels Nov 14, 2024
@matthewmayer matthewmayer added the s: waiting for user interest Waiting for more users interested in this feature label Dec 20, 2024
Copy link
Contributor

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

  • If you would like to see this feature be implemented, please react to the description with an up-vote (:+1:).
  • If you have a suggestion or want to point out some special cases that need to be considered, please leave a comment, so we are aware about them.

We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements.

We will start the implementation based on:

  • the number of votes (:+1:) and comments
  • the relevance for the ecosystem
  • availability of alternatives and workarounds
  • and the complexity of the requested feature

We do this because:

  • There are plenty of languages/countries out there and we would like to ensure that every method can cover all or almost all of them.
  • Every feature we add to faker has "costs" associated to it:
    • initial costs: design, implementation, reviews, documentation
    • running costs: awareness of the feature itself, more complex module structure, increased bundle size, more work during refactors

View more issues which are waiting for user interest

@ST-DDT ST-DDT added this to the vAnytime milestone Dec 20, 2024
@ST-DDT ST-DDT added p: 1-normal Nothing urgent and removed s: waiting for user interest Waiting for more users interested in this feature labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants