Inconsistent default of faker.number.bigInt max option #3364
Labels
breaking change
Cannot be merged when next version is not a major release
c: bug
Something isn't working
m: number
Something is referring to the number module
p: 1-normal
Nothing urgent
s: needs decision
Needs team/maintainer decision
Milestone
Currently, all methods except faker.number.bigInt have a fixed default
max
option:faker/src/modules/number/index.ts
Line 25 in bdd55ad
faker/src/modules/number/index.ts
Line 111 in bdd55ad
faker/src/modules/number/index.ts
Line 229 in bdd55ad
faker/src/modules/number/index.ts
Line 279 in bdd55ad
faker/src/modules/number/index.ts
Line 329 in bdd55ad
vs
faker/src/modules/number/index.ts
Line 377 in bdd55ad
For consistency with the other methods, the
max
value should be hardcoded similar to the other methods.Since this would be a breaking change(?), it should be changed only in the next major version.
Found while reviewing: #3363
The text was updated successfully, but these errors were encountered: