-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename phone.phoneNumber
to phone.number
#693
Labels
good first issue
Good for newcomers
m: phone
Something is referring to the phone module
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Milestone
Comments
xDivisionByZerox
added
s: pending triage
Pending Triage
good first issue
Good for newcomers
s: accepted
Accepted feature / Confirmed bug
and removed
s: pending triage
Pending Triage
labels
Mar 27, 2022
Closed
How would we go about this? Would we simply rename all instances of |
wait on #689, then yes, add deprecation warning + alias |
And remove completely in v7? |
This was referenced Mar 29, 2022
Shinigami92
modified the milestones:
v7.0 - Structural Breaking Changes,
v7 - Current Major
May 24, 2022
This was resolved in #1063. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
Good for newcomers
m: phone
Something is referring to the phone module
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Clear and concise description of the problem
Function name is repeating the module name.
Suggested solution
Create a new function
number
in thephone
module that is a copy of the currentphoneNumber
function. Call this new function in the current function and add a deprecation warning.Alternative
No response
Additional context
Marked as todo in #541
The text was updated successfully, but these errors were encountered: