Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links and Format Missing in Maps #34

Open
EliCylogy opened this issue Aug 3, 2020 · 10 comments
Open

Links and Format Missing in Maps #34

EliCylogy opened this issue Aug 3, 2020 · 10 comments

Comments

@EliCylogy
Copy link

We have two bugs:

1.The links are missing from the descriptions in the maps
2.The paragraph formatting isn’t coming through.

The missing link issue is the most critical of the two bugs.

The content is in sitecore and is pulling from:

/sitecore/content/DotGov/Home/Utils/Interactive Map Content/About Facility

See the missing format and links not working here:

image

Note from our developer after review:

"The new maps requests this item correctly and receives rich HTML with the links inside:

image

It looks like at some point during rendering they were cut and only text is left.

This is on maps developer side: issue should be addressed to Farallon."

Please let me know if you have any questions.

@EliCylogy EliCylogy changed the title Links Missing in Maps Links and Format Missing in Maps Aug 3, 2020
@EliCylogy
Copy link
Author

Note this is happening for all info areas:

image002 (10) (1)

image004 (9) (1)

image004 (8) (1)

The preview link is: http://prod-cm-baaqmd-preview.cylogy.com/Dev-Testing/Maps-New
username: cylogy
password: dev@1234

robgaston added a commit that referenced this issue Aug 3, 2020
@robgaston
Copy link
Contributor

@EliCylogy good catch! this was a bit of regression caused by some fixes we applied earlier this year to better support IE 11. I've just merged a fix in for this here: 5273c30

You should be able to now pull the latest to address this bug; you can see the fix in action here

@Pujapuppy
Copy link

@robgaston Hi Rob - Can you replace styles.scss with this file (and review and merge)? I've moved the style adjustments from baaqmd-maps.css to styles.scss so they won't be overwritten. The new styles.scss is here: https://drive.google.com/drive/folders/1v7w5JXgdnD4ilb9OWvXFP1u2ce3xLEzK?usp=sharing

@EliCylogy
Copy link
Author

Hi @robgaston Can you take a look at Puja's comment above. We need to include the new styles so that we can continue testing today. Can you take a look at this today if possible?

@EliCylogy EliCylogy removed their assignment Aug 11, 2020
@robgaston
Copy link
Contributor

@Pujapuppy @EliCylogy I have updated the styles with your latest from google drive. Please let me know if you need anything else!

@Pujapuppy
Copy link

@robgaston Hi Rob, I adjusted a few more styles - Can you replace styles.scss with this file (and review and merge)? https://drive.google.com/drive/folders/1v7w5JXgdnD4ilb9OWvXFP1u2ce3xLEzK?usp=sharing

@robgaston
Copy link
Contributor

@Pujapuppy @EliCylogy I just updated the repo with the latest supplied by @Pujapuppy above. Let me know if you need anything else!

@Pujapuppy
Copy link

Hi Rob - we found one more issue. I've updated the stylesheet (again). Can you replace styles.css with the new file (and review and merge)?
https://drive.google.com/drive/folders/1v7w5JXgdnD4ilb9OWvXFP1u2ce3xLEzK?usp=sharing

@robgaston
Copy link
Contributor

@Pujapuppy @EliCylogy I updated the repo with the latest from google drive - let me know if you need anything else!

@EliCylogy
Copy link
Author

Thanks @robgaston

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants