-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be more specific on how to run the docker container #5
Comments
yes you are right. the problem is that the commands depend a bit on the OS (e.g. relative paths vs absolute paths for dockers So I generally mount the whole repo folder...
I can add this to the readme, if this makes sense? |
Maybe it is also ok to assume from a user to learn docker, but I wasn't able to figure it out in 10 minutes. Mount the data directory into the docker container and run `run.sh` inside the
container, e.g.:
```bash
docker run -v /home/user/repos/python_audio_loading_benchmark/:/app \
-it audio_benchmark:latest /bin/bash run.sh
``` In addition, it might help to be more explicit if the plot command should also be run in docker and how to access the plots/results. |
looks good, will add this
yes, true. Saving the pickles is also not optimal. I am open to a better pipeline |
That's true, but I was not motivated to change that either. It might also not being worth the effort, but lets see. BTW, I was now able to run the container and reproduce your results. |
When you are not used to docker the current documentation is not very explicit on how to mount and run the actual docker container.
E.g. when I run the following:
I get
And if I log into the container with
I'm in a python console and the content of the folder I'm in is:
The text was updated successfully, but these errors were encountered: