Merge pull request #803 from fastfetch-cli/dev

CarterLi · web-flow · commit 325281269923 · 2024-04-22T23:49:18.000+08:00
Release v2.10.1
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+# 2.10.1
+
+Bugfixes:
+* fix build with `-DENABLE_DBUS=OFF`
+
 # 2.10.0
 
 Changes:
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,7 +1,7 @@
 cmake_minimum_required(VERSION 3.12.0) # target_link_libraries with OBJECT libs & project homepage url
 
 project(fastfetch
-    VERSION 2.10.0
+    VERSION 2.10.1
     LANGUAGES C
     DESCRIPTION "Fast neofetch-like system information tool"
     HOMEPAGE_URL "https://github.com/fastfetch-cli/fastfetch"
diff --git a/src/detection/de/de_linux.c b/src/detection/de/de_linux.c
@@ -43,19 +43,23 @@ static void getKDE(FFstrbuf* result, FFDEOptions* options)
     }
 }
 
-static const char* getGnomeBySo(FFstrbuf* result)
+static const char* getGnomeByDbus(FF_MAYBE_UNUSED FFstrbuf* result)
 {
+#ifdef FF_HAVE_DBUS
     FFDBusData dbus;
     if (ffDBusLoadData(DBUS_BUS_SESSION, &dbus) != NULL)
         return "ffDBusLoadData() failed";
 
     ffDBusGetPropertyString(&dbus, "org.gnome.Shell", "/org/gnome/Shell", "org.gnome.Shell", "ShellVersion", result);
     return NULL;
+#else // FF_HAVE_DBUS
+    return "ffDBusLoadData() failed: dbus support not compiled in";
+#endif // FF_HAVE_DBUS
 }
 
 static void getGnome(FFstrbuf* result, FF_MAYBE_UNUSED FFDEOptions* options)
 {
-    getGnomeBySo(result);
+    getGnomeByDbus(result);
 
     if (result->length == 0 && options->slowVersionDetection)
     {

Original file line number	Diff line number	Diff line change
`@@ -43,19 +43,23 @@ static void getKDE(FFstrbuf* result, FFDEOptions* options)`
`43`	`43`	`}`
`44`	`44`	`}`
`45`	`45`
`46`		`-static const char* getGnomeBySo(FFstrbuf* result)`
	`46`	`+static const char* getGnomeByDbus(FF_MAYBE_UNUSED FFstrbuf* result)`
`47`	`47`	`{`
	`48`	`+#ifdef FF_HAVE_DBUS`
`48`	`49`	`FFDBusData dbus;`
`49`	`50`	`if (ffDBusLoadData(DBUS_BUS_SESSION, &dbus) != NULL)`
`50`	`51`	`return "ffDBusLoadData() failed";`
`51`	`52`
`52`	`53`	`ffDBusGetPropertyString(&dbus, "org.gnome.Shell", "/org/gnome/Shell", "org.gnome.Shell", "ShellVersion", result);`
`53`	`54`	`return NULL;`
	`55`	`+#else // FF_HAVE_DBUS`
	`56`	`+ return "ffDBusLoadData() failed: dbus support not compiled in";`
	`57`	`+#endif // FF_HAVE_DBUS`
`54`	`58`	`}`
`55`	`59`
`56`	`60`	`static void getGnome(FFstrbuf* result, FF_MAYBE_UNUSED FFDEOptions* options)`
`57`	`61`	`{`
`58`		`- getGnomeBySo(result);`
	`62`	`+ getGnomeByDbus(result);`
`59`	`63`
`60`	`64`	`if (result->length == 0 && options->slowVersionDetection)`
`61`	`65`	`{`