Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for Fastify v5 #788

Merged
merged 4 commits into from
May 3, 2024
Merged

Updates for Fastify v5 #788

merged 4 commits into from
May 3, 2024

Conversation

giovanniruzzi
Copy link
Contributor

@giovanniruzzi giovanniruzzi commented Mar 14, 2024 •
edited by simoneb
Loading

What

  • Update to fastify workflow v4.1.0
  • Update dependencies to latest major versions
  • Update unit tests

Why

This PR aims to prepare fastify-swagger for the next version of fastify v5.

Todo

  • Validate changes on unit test

@giovanniruzzi
Copy link
Contributor Author

I'd like to point out key changes in the unit tests. The upgrade to tap v18.5.6 means stricter strictSame checks. Often, schema properties now have an extra parameter [Symbol('json-schema-resolver.ignore')]: true, from json-schema-resolver ref-resolver.js. Tap v16 used libtap, but tap v18 uses tcompare, which is stricter about assertions. I had to use 't.match' instead of 't.strictSame'. I'm considering eliminating the Symbol somehow. Looking for guidance.
Thanks

@giovanniruzzi
Copy link
Contributor Author

@simoneb please have a look

@simoneb
Copy link

simoneb commented Mar 15, 2024

I'd like to point out key changes in the unit tests. The upgrade to tap v18.5.6 means stricter strictSame checks. Often, schema properties now have an extra parameter [Symbol('json-schema-resolver.ignore')]: true, from json-schema-resolver ref-resolver.js. Tap v16 used libtap, but tap v18 uses tcompare, which is stricter about assertions. I had to use 't.match' instead of 't.strictSame'. I'm considering eliminating the Symbol somehow. Looking for guidance. Thanks

I think t.match is an acceptable alternative

@synapse synapse mentioned this pull request Mar 15, 2024
Closed
@gurgunday
Copy link
Member

Hey, any updates?

You can use t.match or an alternative and we will review

@giovanniruzzi giovanniruzzi marked this pull request as ready for review May 3, 2024 12:03
@giovanniruzzi
Copy link
Contributor Author

@gurgunday updated
sorry for the long wait

@gurgunday gurgunday merged commit 542130a into fastify:next May 3, 2024
14 checks passed
@gurgunday
Copy link
Member

Thanks!

jsumners pushed a commit that referenced this pull request Jul 9, 2024
@giovanniruzzi @jsumners
Updates for Fastify v5 (#788)
d533d4f 
* chore: update fastify workflow version

* chore: update dependencies

* chore: update dependencies

* chore: update test and snapshots

---------

Co-authored-by: Giovanni Ruzzi <giovanni.ruzzi@nearform.com>
jsumners pushed a commit that referenced this pull request Jul 15, 2024
@giovanniruzzi @jsumners
Updates for Fastify v5 (#788)
1816120 
* chore: update fastify workflow version

* chore: update dependencies

* chore: update dependencies

* chore: update test and snapshots

---------

Co-authored-by: Giovanni Ruzzi <giovanni.ruzzi@nearform.com>
jsumners added a commit that referenced this pull request Jul 15, 2024
@jsumners @giovanniruzzi @climba03003
Merge next into master (#805)
10f7851 
* Updates for Fastify v5  (#788)

* chore: update fastify workflow version

* chore: update dependencies

* chore: update dependencies

* chore: update test and snapshots

---------

Co-authored-by: Giovanni Ruzzi <giovanni.ruzzi@nearform.com>

* Updates for Fastify v5  (#788)

* chore: update fastify workflow version

* chore: update dependencies

* chore: update dependencies

* chore: update test and snapshots

---------

Co-authored-by: Giovanni Ruzzi <giovanni.ruzzi@nearform.com>

* update fastify deps

* update fastify deps

* Updates for Fastify v5  (#788)

* chore: update fastify workflow version

* chore: update dependencies

* chore: update dependencies

* chore: update test and snapshots

---------

Co-authored-by: Giovanni Ruzzi <giovanni.ruzzi@nearform.com>

* Update .github/workflows/ci.yml

Co-authored-by: KaKa <23028015+climba03003@users.noreply.github.com>
Signed-off-by: James Sumners <321201+jsumners@users.noreply.github.com>

---------

Signed-off-by: James Sumners <321201+jsumners@users.noreply.github.com>
Co-authored-by: Giovanni Ruzzi <gruzzi@gmail.com>
Co-authored-by: Giovanni Ruzzi <giovanni.ruzzi@nearform.com>
Co-authored-by: KaKa <23028015+climba03003@users.noreply.github.com>
@giovanniruzzi giovanniruzzi deleted the next branch August 20, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
v5 Work
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giovanniruzzi @simoneb @gurgunday