fix: apply cargo clippy fixes#4167
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Conversation
- Remove unused import (tauri::Manager) - Remove unnecessary reference conversion (&distinct_id.to_string() -> distinct_id) - Collapse nested if-let chains into combined let-chains - Remove unnecessary lifetime annotations - Exclude plugins/cli2 from workspace (missing Cargo.toml) Co-Authored-By: unknown <>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: apply cargo clippy auto-fixes across workspace
Summary
Ran
cargo clippy --fixandcargo clippyacross the workspace to resolve all auto-fixable clippy warnings. Changes are purely mechanical/cosmetic with no behavioral changes:use tauri::Managerindesktop/src-tauri/src/lib.rs&distinct_id.to_string()→distinct_id(already a&str)tiptap,fs-db, andlistenerwhere nestedif/if letblocks are flattened using Rust's let-chain syntax (if cond && let ... && ...)group_by_session_id<'a, T, F>→group_by_session_id<T, F>in two migration files (elision handles it)plugins/cli2from workspace: This directory only containsnode_moduleswith noCargo.toml, causing workspace resolution failuresNote: Several packages (
tools,control-tauri,notch,am2,tcc,notification-macos) could not be checked because they depend on macOS-only system libraries (swift_rs,libspa,tauri-nspanel) unavailable on Linux.Review & Testing Checklist for Human
from_ast.rs,macro.rs). Confirm the style is acceptable or runcargo fmtto normalize.from_ast.rs: Theunescape_markdownfunction's control flow is correct after collapsing — theresult.push(c)fallthrough andcontinuebehavior should be identical to the original nested version.plugins/cli2exclusion is intentional: The directory has noCargo.toml(removed in commit9a079475b). Adding it toexcludefixes workspace resolution; verify this is the desired fix vs. removing the directory entirely.Notes