Skip to content

Comments

feat: replace 'No calendars found' with 'Request Access to Calendar' button in onboarding#4171

Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin/1771813643-calendar-request-access-button
Open

feat: replace 'No calendars found' with 'Request Access to Calendar' button in onboarding#4171
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin/1771813643-calendar-request-access-button

Conversation

@devin-ai-integration
Copy link
Contributor

Summary

In the onboarding Calendar tab, when the user hasn't granted calendar permission yet, the app previously showed an empty CalendarSelection with "No calendars found." This replaces that empty state with a dedicated "Request Access to Calendar" button.

  • Adds RequestCalendarAccess component with a calendar icon and outline button
  • Checks usePermission("calendar") status in CalendarSection
  • Only renders the calendar list (AppleCalendarList) when permission is authorized; otherwise renders the request button

Review & Testing Checklist for Human

  • UX: Redundant permission UI?ApplePermissions (the red "Calendar" row with arrow button) is still rendered above the new RequestCalendarAccess button. Both trigger calendar.request. Verify this is the intended design, or if ApplePermissions should be hidden/simplified when not yet authorized.
  • Test on macOS: Click "Request Access to Calendar" → system permission dialog appears → grant access → calendar list loads in place of the button.
  • Test deny flow: Deny calendar permission → verify the request button remains visible and functional (re-requesting or opening settings).

Notes

  • The generic CalendarSelection "No calendars found" empty state is unchanged — it just won't be reachable during onboarding anymore since we gate on permission status first.
  • usePermission("calendar") is called unconditionally in CalendarSection even on non-macOS, but the result is only used inside the isMacos branch, so no functional impact.

Requested by: @goranmoomin
Link to Devin run

…button in onboarding

Co-Authored-By: Sungbin Jo <goranmoomin@daum.net>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@netlify
Copy link

netlify bot commented Feb 23, 2026

Deploy Preview for hyprnote-storybook canceled.

Name Link
🔨 Latest commit 826cfbe
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/699bbcd20337bb00083043a3

@netlify
Copy link

netlify bot commented Feb 23, 2026

Deploy Preview for hyprnote canceled.

Name Link
🔨 Latest commit 826cfbe
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/699bbcd232f04d0008de279b

Co-Authored-By: Sungbin Jo <goranmoomin@daum.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant