feat: replace 'No calendars found' with 'Request Access to Calendar' button in onboarding#4171
Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Open
Conversation
…button in onboarding Co-Authored-By: Sungbin Jo <goranmoomin@daum.net>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
Co-Authored-By: Sungbin Jo <goranmoomin@daum.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the onboarding Calendar tab, when the user hasn't granted calendar permission yet, the app previously showed an empty
CalendarSelectionwith "No calendars found." This replaces that empty state with a dedicated "Request Access to Calendar" button.RequestCalendarAccesscomponent with a calendar icon and outline buttonusePermission("calendar")status inCalendarSectionAppleCalendarList) when permission is authorized; otherwise renders the request buttonReview & Testing Checklist for Human
ApplePermissions(the red "Calendar" row with arrow button) is still rendered above the newRequestCalendarAccessbutton. Both triggercalendar.request. Verify this is the intended design, or ifApplePermissionsshould be hidden/simplified when not yet authorized.Notes
CalendarSelection"No calendars found" empty state is unchanged — it just won't be reachable during onboarding anymore since we gate on permission status first.usePermission("calendar")is called unconditionally inCalendarSectioneven on non-macOS, but the result is only used inside theisMacosbranch, so no functional impact.Requested by: @goranmoomin
Link to Devin run