Remove overhead of surrounding block from length-vs-size-vs-count benchmark#97
Closed
radarek wants to merge 1 commit intofastruby:mainfrom
Closed
Remove overhead of surrounding block from length-vs-size-vs-count benchmark#97radarek wants to merge 1 commit intofastruby:mainfrom
radarek wants to merge 1 commit intofastruby:mainfrom
Conversation
…chmark. See fastruby#96 for detailed explanation
Collaborator
|
👍 We should probably write something down, maybe in Contributing.md, about preferring this style where possible. |
| x.report("Array#count") { ARRAY.count } | ||
| x.report("Array#length", "$array.length;" * 1_000) | ||
| x.report("Array#size", "$array.size;" * 1_000) | ||
| x.report("Array#count", "$array.count;" * 1_000) |
There was a problem hiding this comment.
Why are you using a global variable instead of the ARRAY constant?
|
What is the status of this PR? I can work on that. |
Member
|
@benoittgt I believe no one has worked on this for years. Feel free to take a stab at it. 👍🏼 |
Member
|
Closing this because it has had no activity in years. Feel free to re-open if you get to time to address the comments. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #96 for detailed explanation
Before:
After: