PHP incompatibility on PHP > 8?

[mattange]

hi

I found when trying to start v 2.00 (at the related commit) the following when running via docker that this error pops up in console and nothing really shows up on the webpage.

Is there a maximum requirement on PHP? using PHP-FPM with docker-compose. worked as a charm with 8.1 and 1.61
Let me know if you need to know anything else.
As usual - thanks for the great work

rompr-php-1    | NOTICE: PHP message: PHP Fatal error:  Uncaught TypeError: Unsupported operand types: string + int in /ROMPR/includes/prefs.class.php:584
rompr-php-1    | Stack trace:
rompr-php-1    | #0 /ROMPR/backends/sql/sqlite/init_database.class.php(858): prefs::upgrade_host_defs()
rompr-php-1    | #1 /ROMPR/index.php(80): init_database->check_sql_tables()
rompr-php-1    | #2 {main}
rompr-php-1    |   thrown in /ROMPR/includes/prefs.class.php on line 584
rompr-php-1    | 172.23.0.3 -  15/Jan/2023:23:20:06 +0000 "GET /index.php" 500

[fatg3erman]

There should be no limit on PHP version, I'm running 8.1 myself though not in docker but I doubt that's relevant.

The error on that line number is where it is trying to add 2 to a variable. The variable is a string but it should be a numeric string so that should work.

Would you be able to post the contents of prefs/prefs.var here? That file does contain some passwords so if you'd rather not do that then the variable of interest is 'http_port_for_mopidy' which ought to look something like this:

"http_port_for_mopidy";s:4:"6680"

[mattange]

This is what i get in the current config.

....."http_port_for_mopidy";s:0:"";s:10:"multihosts"....

I am one of the crazy ones that have multiple Mopidy targets (2) on same machine (and other ones on other machines) and is NOT using the HTTP interface for those as - as i had discussed in the past with you - i think that meant i could not use them as they have different HTTP ports (but only one could be defined for all of the targets in the past).

Maybe i should reopen the old docker container and remove temporarily the other players and then add them back?
That way i can put a value i suppose in that field for the HTTP port?

Let me know if you think this cunning plan should work!

matteo

[mattange]

i think i solved that via the cunning plan. now i can reach Rompr as before and settings appear there!
yay - although i have not tried to play anything yet as it's late here!!

by converse once i connect - and tried as recommended keeping the prefs and albumart folders - this is what i get on the top right of the page once the connection is successful

Should i perhaps kill the albumart folder and start from scratch?

[fatg3erman]

OK this is making sense now. I'd forgotten to account for the fact that the websocket port might not be a number. In version 2 you can now set the websocket port individually for each player, and I'd recommend you do it.

The second error is odd, I'm not seeing that. But the fact that you're seeing it in the UI suggests that your PHP installation is in 'production' mode rather than 'development' mode - check your php.ini, display_errors should be Off and log_errors should be On.

As for what the error means, it means I have to rewrite some code because PHP have decided I can't do a thing any more. Grr.

[fatg3erman]

If you're struggling to get rid of that error, you can edit util_classes/basealbumimage.class.php and add these lines above the definition of public function __construct

	// Remember to keep albumart_translator in uifunctions.js in step with this

	// We can no longer use dynamic properties so we have to declare all these here.
	protected $artist;
	protected $album;
	protected $key;
	protected $source;
	protected $file;
	protected $base64data;
	protected $mbid;
	protected $albumpath;
	protected $albumuri;
	protected $trackuri;
	protected $dbimage;

[mattange]

Thanks!
so I have used production settings as my php is really out of docker default image and i just use the production-php.ini file

FROM php:8.2.1-fpm
COPY --from=mlocati/php-extension-installer /usr/bin/install-php-extensions /usr/bin/
RUN install-php-extensions gd intl\
        && apt-get update \
        && apt-get install -y imagemagick procps \
        && mv "$PHP_INI_DIR/php.ini-production" "$PHP_INI_DIR/php.ini"
COPY ./rompr-config.ini $PHP_INI_DIR/conf.d/

the last config only has one setting modified vs. production.
You can see default production at [https://github.com/php/php-src/blob/master/php.ini-production](Github url)

I'll let you handle that change as i am more than happy to wait for that!!
Once you mark this as resolved i'll pick up the latest commit :-)

[fatg3erman]

I've alreday fixed it on the develop branch but it won't make it to main until I do another release, which will be some months away.

[fatg3erman]

Fixed in 2.06

[franperr]

Hi, I have installed version 2.06 and PHP 8.2, the message about "creation of dynamic properties" still appears for 3 variables. Adding them to the list remove the message.

public $baseimage;
public $image_downloaded;
public $images;

[franperr]

$basepath must also be added to be able to update podcasts.

[mattange]

Hi Not sure this is relevant but i realised that recently i cannot find / update / subscribe to Apple Podcasts as it used to very easily. Basically nothing is returned upon search, only individual episodes from the other aggregator but not the entire series from apple. But as usual... Excellent in general! Regards

…

On Tue, 19 Sep 2023, 10:40 François, ***@***.***> wrote: $basepath must also be added to be able to update podcasts. — Reply to this email directly, view it on GitHub <#140 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4PJKXKXGKJ2ZNV3HT3NG3X3FK6TANCNFSM6AAAAAAT4EDK2U> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[franperr]

This error was silent on the interface, I found it out by activating the logs. Try activating the logs to see if it is the same problem.

[fatg3erman]

Thanks for reporting. I'll do a 2.07 release in the next day or so to add this fix.

Apple podcasts are working for me. Which podcast were you searching for? It could be another PHP 8 error, but I'm developing using PHP 8.1. I really need to see a debug log.