#102 improve realpath unix management

Author: fdefelici

clove-unit.h

@@ -983,15 +983,15 @@ char* __clove_path_to_absolute(const char* rel_path) {
 
     //case where rel_path not really exists on fs
     //(in this case only the first subpath of the rel_path is added by realpath)
-    if (!__clove_string_endswith(rel_path)) {
+    if (!__clove_string_endswith(result, rel_path)) {
         if (__clove_path_is_absolute(rel_path)) {
-            __clove_string_strcpy(result, _MAX_PATH, rel_path);
+            __clove_string_strcpy(result, PATH_MAX, rel_path);
         } else { //relative
-            realpath(result, ".");
+            realpath(".", result);
             if (!__clove_string_endswith(result, "/")) {
-                __clove_string_strcat(result, _MAX_PATH, "/");
+                __clove_string_strcat(result, PATH_MAX, "/");
             }
-            __clove_string_strcat(result, _MAX_PATH, rel_path);
+            __clove_string_strcat(result, PATH_MAX, rel_path);
         }       
     }
 #endif 

tests/functs/src/unit/path_test.c

@@ -82,7 +82,7 @@ CLOVE_TEST(GetRelativePathFromAbsPath) {
     CLOVE_STRING_EQ(abs_path, result);
 }
 
-CLOVE_TEST(ConvertToAbsolutePath) {
+CLOVE_TEST(ConvertAbsToAbsolutePath) {
     char* result = __clove_path_to_absolute("/abs/path/file.c");
 
     #ifdef _WIN32
@@ -95,3 +95,16 @@ CLOVE_TEST(ConvertToAbsolutePath) {
     __clove_memory_free(result);
 }
 
+CLOVE_TEST(ConvertRelToAbsolutePath) {
+    char* result = __clove_path_to_absolute("rel/path/file.c");
+
+    #ifdef _WIN32
+        const char* result_without_unit = result + 2;  //e.g. c:\abs\path\file.c => \abs\path\file.c
+        CLOVE_STRING_EQ("\\rel\\path\\file.c", result_without_unit);
+    #else
+        CLOVE_IS_TRUE(__clove_string_startswith(result, "/"));
+        CLOVE_IS_TRUE(__clove_string_endswith(result, "/rel/path/file.c"));
+    #endif
+
+    __clove_memory_free(result);
+}