frontend, rpmbuild: skip only if all macros in ExclusiveArch and ExcludeArch evaluated

Fix #3244

It can happen that our builder doesn't understand some architecture macro,
e.g. `%{zig_arches}`. In such a case when it is used in `ExclusiveArch`, we
shouldn't skip all chroots like we do now. A better approach is to be safe and
avoid any skipping. Builds will fail in some chroots that should have been
skipped but that can be workarounded by the user by manually submitting the
build only for a subset of chroots.

Author: FrostyX

frontend/coprs_frontend/coprs/logic/builds_logic.py

@@ -1132,15 +1132,19 @@ def finish(chroot, status):
 
                     exclusivearch = upd_dict["results"].get("exclusivearch")
                     if exclusivearch and arch not in exclusivearch:
-                        chroot.status_reason = \
-                            "This chroot was skipped because of ExclusiveArch"
-                        finish(chroot, StatusEnum("skipped"))
+                        # Skip only if all macros in ExclusiveArch evaluated
+                        if not [x for x in exclusivearch if x.startswith("%")]:
+                            chroot.status_reason = \
+                                "This chroot was skipped because of ExclusiveArch"
+                            finish(chroot, StatusEnum("skipped"))
 
                     excludearch = upd_dict["results"].get("excludearch")
                     if arch in excludearch:
-                        chroot.status_reason = \
-                            "This chroot was skipped because of ExcludeArch"
-                        finish(chroot, StatusEnum("skipped"))
+                        # Skip only if all macros in ExcludeArch evaluated
+                        if not [x for x in excludearch if x.startswith("%")]:
+                            chroot.status_reason = \
+                                "This chroot was skipped because of ExcludeArch"
+                            finish(chroot, StatusEnum("skipped"))
 
             cls.process_update_callback(build)
             db.session.add(build)

frontend/coprs_frontend/tests/test_logic/test_builds_logic.py

@@ -655,3 +655,43 @@ def save_field(_field, file_path):
         build = models.Build.query.get(1)
         assert build.source_state == "succeeded"
         assert not os.path.exists(storage)
+
+    @pytest.mark.parametrize(
+        "exclusivearch,states", [
+            (["x86_64", "i386"], ["waiting", "waiting"]),
+            (["x86_64"], ["waiting", "skipped"]),
+            (["x86_64", "%{zig_arches}"], ["waiting", "waiting"]),
+            ([], ["waiting", "waiting"]),
+        ]
+    )
+    def test_skipping_chroots(self, exclusivearch, states, f_users, f_coprs,
+                              f_builds, f_mock_chroots, f_db):
+        build = BuildsLogic.add(self.u2, "foo", self.c2)
+        self.db.session.commit()
+        assert len(build.chroots) == 0
+        data = {
+            "builds": [{
+                "id": 5,
+                "task_id": 5,
+                "srpm_url": "http://foo",
+                "status": 1,
+                "pkg_name": "foo",
+                "pkg_version": 1,
+                "chroot": "srpm-builds",
+                "results": {
+                    "epoch": None,
+                    "excludearch": [],
+                    "exclusivearch": exclusivearch,
+                    "name": "biosdevname",
+                    "release": "17",
+                    "version": "0.7.3"
+                },
+            }]
+        }
+        response = self.tc.post(
+            "/backend/update/",
+            headers=self.auth_header,
+            json=data,
+        )
+        assert response.status_code == 200
+        assert [x.state for x in build.build_chroots] == states

rpmbuild/copr_rpmbuild/helpers.py

@@ -428,14 +428,22 @@ def exclusivearch(self):
         """
         Evaluated %{exclusivearch} as a list
         """
-        return self.safe_attr("exclusivearch").split()
+        values = self.safe_attr("exclusivearch").split()
+        for macro in values:
+            if macro.startswith("%"):
+                log.warning("Unknown macro in ExclusiveArch: %s", macro)
+        return values
 
     @property
     def excludearch(self):
         """
         Evaluated %{excludearch} as a list
         """
-        return self.safe_attr("excludearch").split()
+        values = self.safe_attr("excludearch").split()
+        for macro in values:
+            if macro.startswith("%"):
+                log.warning("Unknown macro in ExcludeArch: %s", macro)
+        return values
 
     def safe_attr(self, name):
         """